Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(group): autocli query support #17006

Merged
merged 6 commits into from
Jul 17, 2023
Merged

feat(group): autocli query support #17006

merged 6 commits into from
Jul 17, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 15, 2023 •
edited
Loading

Description

Closes: #15901

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt mentioned this pull request Jul 15, 2023
Closed
17 tasks
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 15, 2023
@julienrbrt julienrbrt mentioned this pull request Jul 17, 2023
Closed
julienrbrt
julienrbrt commented Jul 17, 2023
View reviewed changes
x/group/module/autocli.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added only tests for the surface that became untested. As part of #16757, we should move the remaining e2e tests from there (that tests proposals tx and queries) here.

@julienrbrt julienrbrt marked this pull request as ready for review July 17, 2023 11:30
@julienrbrt julienrbrt requested a review from a team as a code owner July 17, 2023 11:30
@github-actions
Copy link
Contributor

@julienrbrt your pull request is missing a changelog!

@julienrbrt julienrbrt mentioned this pull request Jul 17, 2023
Merged
19 tasks
@julienrbrt
Copy link
Member Author

@julienrbrt your pull request is missing a changelog!

Nope, we use one changelog for the whole autocli query migration.

likhita-809
likhita-809 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@julienrbrt julienrbrt added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 7eb85db Jul 17, 2023
50 checks passed
@julienrbrt julienrbrt deleted the julien/autocli-group branch July 17, 2023 13:00
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@julienrbrt @mergify
feat(group): autocli query support (#17006)
d9bbfa6 
(cherry picked from commit 7eb85db)

# Conflicts:
#	x/group/keeper/grpc_query_test.go
@mergify mergify bot mentioned this pull request Jul 17, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 17, 2023
@mergify @julienrbrt
feat(group): autocli query support (backport #17006) (#17028)
d23caef 
Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Query Module Configurations for AutoCLI
2 participants
@julienrbrt @likhita-809