Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit x/group v0.47...v0.50 #16817

Closed
julienrbrt opened this issue Jul 3, 2023 · 3 comments
Closed

Audit x/group v0.47...v0.50 #16817

julienrbrt opened this issue Jul 3, 2023 · 3 comments
Assignees
@julienrbrt @likhita-809
Labels
C:x/group T: Audit

Comments

@julienrbrt
Copy link
Member

No description provided.

@julienrbrt julienrbrt mentioned this issue Jul 3, 2023
Closed
52 tasks
@julienrbrt julienrbrt changed the title Audit x/group v0.47...v0.50 (@julienrbrt + TBD) Audit x/group v0.47...v0.50 Jul 3, 2023
@julienrbrt julienrbrt self-assigned this Jul 3, 2023
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Jul 3, 2023
@julienrbrt julienrbrt added T:Sprint T: Audit C:x/group and removed needs-triage Issue that needs to be triaged labels Jul 3, 2023
@likhita-809 likhita-809 self-assigned this Jul 5, 2023
@julienrbrt
Copy link
Member Author

julienrbrt commented Jul 6, 2023 •
edited
Loading

Changes:

  • ValidateBasic has been removed, which made CLI check more verbose.
  • Changing store types to store packages
  • Delete duplicated tests
  • No other core logic changes

I'll be testing group manually too tomorrow.

@likhita-809 likhita-809 mentioned this issue Jul 13, 2023
Merged
19 tasks
@likhita-809
Copy link
Contributor

@julienrbrt is group module testing done ?

@julienrbrt
Copy link
Member Author

@julienrbrt is group module testing done ?

Yep, but just adding some tests as part of #17006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

@likhita-809 likhita-809

Labels
C:x/group T: Audit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienrbrt @likhita-809