Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Python in tests #371

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Unpin Python in tests #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eedf7b
Unpin Python in tests
xhochy Nov 26, 2024
1f67e66
MNT: Re-rendered with conda-build 24.11.1, conda-smithy 3.44.8, and c…
xhochy Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/azure-pipelines-linux.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .ci_support/linux_64_.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ channel_sources:
channel_targets:
- conda-forge main
docker_image:
- quay.io/condaforge/linux-anvil-cos7-x86_64
- quay.io/condaforge/linux-anvil-x86_64:alma9
pin_run_as_build:
python:
min_pin: x.x
Expand Down
8 changes: 6 additions & 2 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ source:
- patches/0021-Add-d1trimfile-SRC_DIR-to-make-pdbs-more-relocatable.patch

build:
number: 0
number: 1
noarch: python

requirements:
Expand All @@ -23,7 +23,11 @@ requirements:

test:
requires:
- python {{ python_min }}
# The linter will complain about the missing python_min, but we need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, since I had a need to ignore the linter elsewhere already: is there a way to tell the linter "this is intended"? Something like the # type: ignore for Mypy or # noqa: for Ruff?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing structured like that, because smithy is just string-parsing, mainly (things should get easier with the v1 recipe).

However, Isuru recently introduced a mechanism opt out of certain lints, which could be extended to python_min

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conda-forge/conda-smithy#2170

# this unpinned to allow setuptools to be used in the downstream tests
# of the python-feedstock.
# See also https://github.com/conda-forge/conda-forge.github.io/pull/2387
- python
imports:
- setuptools
- pkg_resources
Expand Down