-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin Python in tests #371
Conversation
…onda-forge-pinning 2024.11.26.07.33.56
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12032974171. Examine the logs at this URL for more detail. |
@@ -23,7 +23,11 @@ requirements: | |||
|
|||
test: | |||
requires: | |||
- python {{ python_min }} | |||
# The linter will complain about the missing python_min, but we need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question, since I had a need to ignore the linter elsewhere already: is there a way to tell the linter "this is intended"? Something like the # type: ignore
for Mypy or # noqa:
for Ruff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing structured like that, because smithy is just string-parsing, mainly (things should get easier with the v1 recipe).
However, Isuru recently introduced a mechanism opt out of certain lints, which could be extended to python_min
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)