Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Python in tests #371

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Nov 26, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12032974171. Examine the logs at this URL for more detail.

@xhochy xhochy merged commit 85a8fc8 into conda-forge:main Nov 26, 2024
4 checks passed
@xhochy xhochy deleted the unpin-python-in-tests branch November 26, 2024 14:49
@@ -23,7 +23,11 @@ requirements:

test:
requires:
- python {{ python_min }}
# The linter will complain about the missing python_min, but we need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, since I had a need to ignore the linter elsewhere already: is there a way to tell the linter "this is intended"? Something like the # type: ignore for Mypy or # noqa: for Ruff?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing structured like that, because smithy is just string-parsing, mainly (things should get easier with the v1 recipe).

However, Isuru recently introduced a mechanism opt out of certain lints, which could be extended to python_min

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants