Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger-ui 2.0.22, swagger.js 2.0.37 #92

Merged
merged 5 commits into from
Sep 11, 2014

Conversation

Novarg
Copy link
Contributor

@Novarg Novarg commented Sep 11, 2014

Continue from this: #58

Updated to the latest swagger-ui

Also 2 additional features to build extra actions in this pull request:

  • added support for paramType=body in extra actions
  • respect Meta.excludes option when building resource schema

I can't really cut off them without touching commit history so i decided to leave them in this pull request

johnraz added a commit that referenced this pull request Sep 11, 2014
Swagger-ui 2.0.22, swagger.js 2.0.37
@johnraz johnraz merged commit 99189d3 into concentricsky:master Sep 11, 2014
@johnraz
Copy link
Contributor

johnraz commented Sep 11, 2014

Looks good enough to me :) Thx for the contrib :)

@johnraz johnraz mentioned this pull request Sep 11, 2014
@Seraf
Copy link

Seraf commented Sep 11, 2014

Hi, @johnraz and @Novarg, I tried the last master with this PR, but got some problems.
I collected the static files to be sure to use the new js/css provided, and going to api/docs :

It gives me this error message on javascript side:
Uncaught Template was precompiled with an older version of Handlebars than the current runtime. Please update your precompiler to a newer version (>= 1.0.0) or downgrade your runtime to an older version (<= 1.0.rc.2). handlebars-1.0.0.js:2223

And it seems to try to load the wordnik api petstore.

Do I need some new extra config ? With last stable release, it worked nice maybe I miss something ?

Thanks

@johnraz
Copy link
Contributor

johnraz commented Sep 11, 2014

Thx for the feedback @Seraf I must admit I didn't test it :)
@Novarg may I ask you to give some extra love ?

@Novarg
Copy link
Contributor Author

Novarg commented Sep 12, 2014

@Seraf are you sure you are using fresh swagger-ui.js from updated package? Maybe browser cached old one? Could you flush cache if you didn't do that previously?
Also if you are using custom django template could you check that all includes there use right path and versions?

I just rechecked my setup and doesn't saw anything wrong.

@Seraf
Copy link

Seraf commented Sep 12, 2014

Sorry it works now, I think a didn't copy correctly the files...
Everything works now and I checked in the swagger.js file, it's the good version :)

Just for information, is it normal that the interface isn't same that http://petstore.swagger.wordnik.com/#!/pet/addPet ?

Thanks

@Novarg
Copy link
Contributor Author

Novarg commented Sep 12, 2014

Just for information, is it normal that the interface isn't same that http://petstore.swagger.wordnik.com/#!/pet/addPet ?

well, it's depending on what exactly differ, some data not provided by django-tastypie-swagger i think (like some titles for resources, etc). And oauth stuff not used by default in django template. But if i missed something and you think something looks wrong you can open issue with screenshots of even make a pull request :)

@johnraz
Copy link
Contributor

johnraz commented Sep 12, 2014

Again as I several time pointed out yet, there is specification for the the swagger.js project that this project is not full filling. I started a branch here to try to address this but it requires more work as I would like to have unit tests in at the same time ;-)

@Seraf
Copy link

Seraf commented Oct 1, 2014

@Novarg @johnraz Hi, since this update, I think the api_key was broken (in the topbar).
I have a 401 on my protected resources even if I use my apikey. Do you have the problem on your side ? (the api works with POSTMAN client so problem is not on server side)

Thanks

@johnraz
Copy link
Contributor

johnraz commented Oct 2, 2014

@Seraf afaik this issue has been there for a while see #71 - it could be fixed with 2.0 with a few effort I think, would be awesome if you could look into it ;-)

@Seraf
Copy link

Seraf commented Oct 2, 2014

Hi @johnraz it's a regression, it was working in this commit : 1bb078b

I will try to find where it was broken when I will have some free time.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants