Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swagger ui v2.0.0 #36

Closed
wants to merge 5 commits into from
Closed

Upgrade swagger ui v2.0.0 #36

wants to merge 5 commits into from

Conversation

marcusrbrown
Copy link

This is a followup to #34. There were a few minor changes to the resources/ and schema/ views, as Swagger 2.0 expects an absolute URI in basePath, and basePath is concatenated to the resource, so it can't have a trailing slash. I also bumped the Swagger version to 2.0, although I don't see this being used anywhere in Swagger UI.

@marcusrbrown
Copy link
Author

I found https://github.com/wordnik/swagger-core/wiki/1.2-transition which gives a breakdown of swaggerVersion. Reverted the change from 1.1 to 2.0 (which wouldn't make sense).

If this is accepted, I'd like to do an actual transition to the Swagger 1.2 definition.

@fehguy
Copy link

fehguy commented Aug 20, 2013

you mean you set the swaggerVersion to 1.2, correct? The tools read this and expect that format, so best if it can follow the swagger spec versioning

@marcusrbrown
Copy link
Author

Yes, but django-tastypie-swagger doesn't strictly adhere to the 1.2 spec. I'd like to fix that in a separate PR. My goof was in thinking it was tied to the Swagger UI version I integrated, instead of the spec version.

@fehguy
Copy link

fehguy commented Aug 20, 2013

OK just making sure the spec isn't set to 2.0, since there's no such thing. Also in the transition process, you might find this valuable:

https://github.com/wordnik/swagger-codegen#migrating-from-swagger-11-to-12-format

If you need help, please ask in #swagger, irc.freenode.net. Great job on this project!

@johnraz
Copy link
Contributor

johnraz commented Feb 10, 2014

Let's make this the latest (2.0.9) and move on.

@fehguy
Copy link

fehguy commented Mar 19, 2014

Hi folks, the specification for swagger has been moved into this repository:

https://github.com/wordnik/swagger-spec

which should make it much easier to verify the JSON output.

@Seraf
Copy link

Seraf commented Sep 11, 2014

Hello, is there some news about this ? :)

@johnraz
Copy link
Contributor

johnraz commented Sep 11, 2014

should be covered by #92

@johnraz johnraz closed this Sep 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants