-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial preparation for supporting writing to any/all cdf targets #435
Merged
Merged
Changes from 15 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
b73a0c8
proposed
toondaey b450ec5
latest
renovate[bot] fa3bd31
test: fix last failing test
toondaey 788763c
Merge remote-tracking branch 'origin/master' into support-writing-to-…
toondaey 455d5a3
feat: segregation
toondaey 7bdfc2d
refactor: extract writers
toondaey 8007bd3
Merge remote-tracking branch 'origin/master' into support-writing-to-…
toondaey 43b872e
test: fix failing tests
toondaey ecc6e87
test: fix failing test
toondaey 5722538
refactor: remove cancellation token from constructors
toondaey f32c279
fix: fix config
toondaey f9ce232
feat: integrate new config pattern
toondaey 70fe544
docs: include methods documentations
toondaey 39bb59e
style: deprecate property
toondaey 055eba1
docs: json docs
toondaey 39f874f
Merge master into support-writing-to-all/dog-1760
cognite-bulldozer[bot] 74ce0ea
Merge refs/heads/master into support-writing-to-all/dog-1760
cognite-bulldozer[bot] 672e7a8
style: rename config
toondaey 5638738
refactor: abstract away
toondaey 74daae8
feat: abstract timeseries
toondaey 7e6fb95
docs: update use of metdata targets
toondaey bf4f439
fix: failing tests
toondaey fd95145
fix: failing test
toondaey e52f1a1
test: test all pusher destination
toondaey 0a1d40c
test: remove all clear from all destination test
toondaey 7deb336
test: without all destination
toondaey 503a386
fix: failing test
toondaey 57a065a
Merge refs/heads/master into support-writing-to-all/dog-1760
cognite-bulldozer[bot] 92af8b2
Merge refs/heads/master into support-writing-to-all/dog-1760
cognite-bulldozer[bot] c0bff31
Merge refs/heads/master into support-writing-to-all/dog-1760
cognite-bulldozer[bot] d148877
fix: failing test
toondaey a45519e
fix: failing test
toondaey 25c1fbb
docs: documentation updated
toondaey 62b4864
Merge refs/heads/master into support-writing-to-all/dog-1760
cognite-bulldozer[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,4 @@ | |
] | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ You should have received a copy of the GNU General Public License | |
|
||
using Cognite.Extensions; | ||
using Cognite.Extractor.Utils; | ||
using System; | ||
using System.Collections.Generic; | ||
using System.ComponentModel; | ||
using System.ComponentModel.DataAnnotations; | ||
|
@@ -56,6 +57,7 @@ public class CognitePusherConfig : CogniteConfig, IPusherConfig | |
/// similarly to raw-metadata, and datapoints will be pushed. Nothing will be written to raw, and no assets will be created. | ||
/// Events will be created, but without asset context. | ||
/// </summary> | ||
[Obsolete("Deprecated!")] | ||
public bool SkipMetadata { get; set; } | ||
/// <summary> | ||
/// Store assets and/or timeseries data in raw. Assets will not be created at all, | ||
|
@@ -65,6 +67,7 @@ public class CognitePusherConfig : CogniteConfig, IPusherConfig | |
/// of the source node is added to metadata if applicable. | ||
/// Use different table names for assets and timeseries. | ||
/// </summary> | ||
[Obsolete("Deprecated! Use MetadataTargetsConfig.RawMetadataTargetConfig instead.")] | ||
public RawMetadataConfig? RawMetadata { get; set; } | ||
/// <summary> | ||
/// Map metadata to asset/timeseries attributes. Each of "assets" and "timeseries" is a map from property DisplayName to | ||
|
@@ -114,7 +117,13 @@ public double? NonFiniteReplacement | |
/// <summary> | ||
/// Configuration for writing to a custom OPC-UA flexible data model. | ||
/// </summary> | ||
[Obsolete("Deprecated! Use MetadataTargetsConfig.FdmDestinationConfig instead.")] | ||
public FdmDestinationConfig? FlexibleDataModels { get; set; } | ||
|
||
/// <summary> | ||
/// This is the implementation of the metadata targets | ||
/// </summary> | ||
public MetadataTargetsConfig? MetadataTargets { get; set; } | ||
} | ||
public class RawMetadataConfig | ||
{ | ||
|
@@ -136,6 +145,34 @@ public class RawMetadataConfig | |
/// </summary> | ||
public string? RelationshipsTable { get; set; } | ||
} | ||
public class MetadataTargetsConfig | ||
{ | ||
/// <summary> | ||
/// Raw metadata targets config | ||
/// </summary> | ||
public RawMetadataTargetConfig? RawMetadata { get; set; } | ||
/// <summary> | ||
/// Clean metadata targets config | ||
/// </summary> | ||
public CleanMetadataTargetConfig? CleanMetadata { get; set; } | ||
/// <summary> | ||
/// FDM destination config | ||
/// </summary> | ||
public FdmDestinationConfig? FlexibleDataModels { get; set; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be data-models |
||
} | ||
public class RawMetadataTargetConfig | ||
{ | ||
public string? Database { get; set; } | ||
public string? AssetsTable { get; set; } | ||
public string? TimeseriesTable { get; set; } | ||
public string? RelationshipsTable { get; set; } | ||
} | ||
public class CleanMetadataTargetConfig | ||
{ | ||
public bool Assets { get; set; } = true; | ||
public bool Timeseries { get; set; } = true; | ||
public bool Relationships { get; set; } = true; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These shouldn't be true by default |
||
} | ||
public class MetadataMapConfig | ||
{ | ||
public Dictionary<string, string>? Assets { get; set; } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just call this
clean
, andraw