Initial preparation for supporting writing to any/all cdf targets #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
+ Coverage 83.72% 83.75% +0.03%
==========================================
Files 98 108 +10
Lines 16064 16453 +389
Branches 2489 2492 +3
==========================================
+ Hits 13449 13780 +331
- Misses 1870 1921 +51
- Partials 745 752 +7
|
toondaey
force-pushed
the
support-writing-to-all/dog-1760
branch
from
b7b5102
to
fa3bd31
Compare
toondaey
force-pushed
the
support-writing-to-all/dog-1760
branch
from
0d51110
to
5722538
Compare
toondaey
changed the title
toondaey
force-pushed
the
support-writing-to-all/dog-1760
branch
from
d71ee13
to
70fe544
Compare
einarmo
requested changes
Jul 24, 2023
| { | ||
| IRawWriter Raw { get; } | ||
| ITimeseriesWriter Timeseries { get; } | ||
| ITimeseriesWriter MinimalTimeseries { get; } |
There was a problem hiding this comment.
Remove this, and use an abstraction instead, so the Timeseries field is either a MinimalTimeseriesWriter, or FullTimeseriesWriter.
| var tss = ids.Select(id => tsMap[id]); | ||
| var creates = tss.Select( | ||
| ts => | ||
| ts.ToTimeseries( |
There was a problem hiding this comment.
Split the ToTimeseries method as well, and call it from subclasses of some BaseTimeseriesWriter class.
| } | ||
| }; | ||
| } | ||
| if (config.Cognite?.FlexibleDataModels != null) |
There was a problem hiding this comment.
You don't need this mapping, because this isn't public.
schema/cognite_config.schema.json
Outdated
| @@ -57,6 +59,100 @@ | |||
| } | |||
| } | |||
| }, | |||
There was a problem hiding this comment.
Remove these blocks entirely.
Extractor/Config/CogniteConfig.cs
Outdated
| { | ||
| public bool Assets { get; set; } = true; | ||
| public bool Timeseries { get; set; } = true; | ||
| public bool Relationships { get; set; } = true; |
There was a problem hiding this comment.
These shouldn't be true by default
Extractor/Config/CogniteConfig.cs
Outdated
| /// <summary> | ||
| /// Clean metadata targets config | ||
| /// </summary> | ||
| public CleanMetadataTargetConfig? CleanMetadata { get; set; } |
There was a problem hiding this comment.
Just call this clean, and raw
Extractor/Config/CogniteConfig.cs
Outdated
| /// <summary> | ||
| /// FDM destination config | ||
| /// </summary> | ||
| public FdmDestinationConfig? FlexibleDataModels { get; set; } |
einarmo
reviewed
Jul 27, 2023
schema/cognite_config.schema.json
Outdated
| "assets-table": { | ||
| "type": "string", | ||
| "description": "Raw table to use for assets" | ||
| "raw-metadata": { |
There was a problem hiding this comment.
You changed the name of these in config, need to update here too.
There was a problem hiding this comment.
Also, I think you need to update the example config file.
einarmo
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.