Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add multiarch docker #237

Closed
wants to merge 6 commits into from
Closed

Conversation

tuananh
Copy link

@tuananh tuananh commented Dec 15, 2023

Fixes: #185

I'm testing in my fork so I use runs-on: ubuntu-latest for now. Will change before the PR lands.

Summary:

  • Use docker buildx bake to build multi-arch image.
  • Enable linux/amd64 and linux/arm64 for now
  • I have only update the base image for now. I'm not sure if other images have all the packages needed for arm64. Potentially, python or any instruction we download binaries from other places.
  • Build seems to work fine in my fork (ignore the scan image step) https://github.com/tuananh/enterprise-images/actions/runs/7217598019/job/19665669577

Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
@tuananh
Copy link
Author

tuananh commented Dec 15, 2023

@johnstcn is this something you ok with so that I can proceed?

@johnstcn
Copy link
Member

@johnstcn is this something you ok with so that I can proceed?

Hey, so the basic approach looks fine to me.
However, I'd like to do some further TLC on this repo before adding multi-arch images if that's OK?

@tuananh
Copy link
Author

tuananh commented Dec 16, 2023

@johnstcn is this something you ok with so that I can proceed?

Hey, so the basic approach looks fine to me. However, I'd like to do some further TLC on this repo before adding multi-arch images if that's OK?

Sure :)

@johnstcn
Copy link
Member

@johnstcn is this something you ok with so that I can proceed?

Hey, so the basic approach looks fine to me. However, I'd like to do some further TLC on this repo before adding multi-arch images if that's OK?

Sure :)

I had a poke around at this in cj/buildx, I can get a certain distance before running into package issues. Will continue poking next chance I get.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build arm64 images as part of pipeline
3 participants