-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build multiarch images #244
Conversation
What is a safer way to test pushing? depot can push automatically, but here we are first scanning and then pushing manually. |
I think manually pushing is probably OK here; we can test one image/tag and if successful then push automatically. |
I tested this out by performing the following steps on an arm64 machine (macOS):
Result: workspace built successfully from template |
closes #185, closes #237
Important
The build and push script requires depot CLI to be set up and fail if run locally and the depot is unavailable. We can add a fallback method to use docker CLI in a follow-up PR (docker needs a bit more work to push multi-arch image manifest)