Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build multiarch images #244

Merged
merged 8 commits into from
Jan 16, 2024
Merged

feat: build multiarch images #244

merged 8 commits into from
Jan 16, 2024

Conversation

matifali
Copy link
Member

@matifali matifali commented Jan 16, 2024

closes #185, closes #237

Important

The build and push script requires depot CLI to be set up and fail if run locally and the depot is unavailable. We can add a fallback method to use docker CLI in a follow-up PR (docker needs a bit more work to push multi-arch image manifest)

@matifali matifali marked this pull request as ready for review January 16, 2024 09:41
@matifali
Copy link
Member Author

What is a safer way to test pushing? depot can push automatically, but here we are first scanning and then pushing manually.

@johnstcn
Copy link
Member

What is a safer way to test pushing? depot can push automatically, but here we are first scanning and then pushing manually.

I think manually pushing is probably OK here; we can test one image/tag and if successful then push automatically.

@johnstcn
Copy link
Member

johnstcn commented Jan 16, 2024

I tested this out by performing the following steps on an arm64 machine (macOS):

  • Editing out the line installing tonistiigi/binfmt in examples/lima/coder.yaml
  • limactl start --name=coder ./examples/lima/coder.yaml
  • Created basic Docker template
  • Modified Docker template to reference image from depot.dev
  • (Note: I had to manually pull the image inside the VM using the depot cli as I couldn't figure out how to pass basic auth creds for depot to the Docker daemon)

Result: workspace built successfully from template

image

image

image

@matifali matifali merged commit 5fb04fd into main Jan 16, 2024
4 checks passed
@matifali matifali deleted the multi-arch branch January 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build arm64 images as part of pipeline
2 participants