This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Added benchmarks for GEMM complex types #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
force-pushed
the
complex_gemm_bench_pr
branch
from
b512524 to
d45904a
Compare
s-Nick
approved these changes
Oct 17, 2023
OuadiElfarouki
force-pushed
the
complex_gemm_bench_pr
branch
from
51a51a0 to
3e3d4dc
Compare
OuadiElfarouki
requested review from
muhammad-tanvir-1211,
pgorlani and
aacostadiaz
| reinterpret_cast<void*>(c_ref.data() + _base(m, n, batch_idx)), ldc); | ||
| } | ||
|
|
||
| if (batch_type == blas::gemm_batch_type_t::interleaved) { |
There was a problem hiding this comment.
I think it's best if we move this check before the #ifdef BLAS_VERIFY_BENCHMARK block to avoid calling the reference implementation.
| std::tie(t1s, t2s, m, k, n, alpha_r, alpha_i, beta_r, beta_i, batch_size, | ||
| batch_type) = p; | ||
| // Only batch_type == strided is supported with Complex data | ||
| if (batch_type == 1) { |
There was a problem hiding this comment.
If we want to keep this check here than we don't really need to check for the batch_type in run() function since we are manually choosing the type of data layout that is going to be called for the run() function.
muhammad-tanvir-1211
approved these changes
Oct 26, 2023
muhammad-tanvir-1211
merged commit 8d29746
into
codeplaysoftware:master
3 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends portBLAS, cuBLAS & rocBLAS benchmarks to complex
(float & double)data types for Gemm, GemmBatched and GemmBatchedStrided operators.