Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockpit-desktop: Support Firefox flatpak #21224

Merged
merged 2 commits into from
Nov 6, 2024
Merged

cockpit-desktop: Support Firefox flatpak #21224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a3648
cockpit-desktop: Support Firefox flatpak
martinpitt Nov 6, 2024
cbeaadc
cockpit-desktop: Add firefox profile to hide privacy bar/tab and book…
martinpitt Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/ws/cockpit-desktop.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ set -eu
exec_prefix="@prefix@"
libexecdir="@libexecdir@"

# start browser in a temporary home dir, so that it does not interfere with your real one
BROWSER_HOME=$(mktemp --directory --tmpdir cockpit.desktop.XXXXXX)
export BROWSER_HOME

# find suitable browser, unless already set by $BROWSER
# We can't use xdg-open, it does too much magic behind the back to connect to
# existing instances (outside of our namespace) and does not allow us to reduce
Expand All @@ -63,13 +67,28 @@ detect_browser()
fi
done

# create firefox profile
FIREFOX_PROFILE="$BROWSER_HOME/profile"
mkdir "$FIREFOX_PROFILE"
cat <<EOF > "$FIREFOX_PROFILE/user.js"
user_pref("datareporting.policy.dataSubmissionEnabled", false);
user_pref("toolkit.telemetry.reportingpolicy.firstRun", false);
user_pref("browser.toolbars.bookmarks.visibility", "never");
EOF

if type firefox >/dev/null 2>&1; then
# TODO: Find a way to disable the privacy notice tab, via mozilla.cfg?
# TODO: Find a way to disable the URL bar
BROWSER="firefox --no-remote"
BROWSER="firefox --profile $FIREFOX_PROFILE --no-remote"
return 0
fi

for id in org.mozilla.firefox org.mozilla.Firefox; do
if flatpak info $id >/dev/null 2>&1; then
BROWSER="flatpak run --filesystem=$BROWSER_HOME $id --profile $FIREFOX_PROFILE --no-remote"
return 0
fi
done

# TODO: is there a simple way to use webkitgtk?
echo "No suitable browser found (Chromium/Chrome, or Firefox)" >&2
exit 1
Expand Down Expand Up @@ -109,9 +128,6 @@ set -eu
# new namespaces have lo down by default
ip link set lo up >&2

# start browser in a temporary home dir, so that it does not interfere with your real one
export BROWSER_HOME=$(mktemp --directory --tmpdir cockpit.desktop.XXXXXX)

# forward parent stdin and stdout (from bridge) to cockpit-ws
# it pretty well does not matter which port we use in our own namespace, so use standard http
# disable /etc/cockpit/
Expand Down