cockpit-desktop: Support Firefox flatpak #21224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RHEL 10 does not ship Firefox as RPM any more, and will instead use a flatpak. For now, check for/run the IDs of the official upstream Mozilla Firefox on flathub and the RHEL flatpak [1]. Surprisingly, `flatpak run` works fine inside our little network namespace. https://issues.redhat.com/browse/RHEL-65847 [1] https://catalog.redhat.com/search?gs&q=firefox-flatpak
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…marks This makes the cockpit-desktop experience a bit more tasteful with Firefox -- avoid the second broken tab (with the privacy note, which you can't open anyway as this is an isolated network namespace), and disable data submission to avoid the privacy hint notification bar. Also disable the bookmark toolbar. It doesn't appear by default with the upstream Firefox flatpak, but it does show with the Fedora version. Move `BROWSER_HOME` out of the inner script into the top-level, so that the browser profile can be created inside it.
jelly
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL 10 does not ship Firefox as RPM any more, and will instead use a flatpak. For now, check for/run the IDs of the official upstream Mozilla Firefox on flathub and the RHEL flatpak [1].
Surprisingly,
flatpak runworks fine inside our little network namespace.https://issues.redhat.com/browse/RHEL-65847
[1] https://catalog.redhat.com/search?gs&q=firefox-flatpak
cockpit-desktop: Add firefox profile to hide privacy bar/tab and bookmarks
This makes the cockpit-desktop experience a bit more tasteful with
Firefox -- avoid the second broken tab (with the privacy note, which you can't
open anyway as this is an isolated network namespace), and disable data
submission to avoid the privacy hint notification bar.
Also disable the bookmark toolbar. It doesn't appear by default with the
upstream Firefox flatpak, but it does show with the Fedora version.
Move
BROWSER_HOMEout of the inner script into the top-level, so thatthe browser profile can be created inside it.
I installed current RHEL 10 nightly ISO and confirmed the broken cockpit-desktop subscription link. With the flatpak fix, it works again, but looks rather ugly in the default profile:
This wasn't a problem in RHEL 8/9 as that used webkit GTK. With the custom profile it looks like this:
I didn't find a way to hide the tab bar. Hiding some more elements would also be nice, but let's do that as a follow-up.