fmf: Declare our own dependencies #19168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmt implicitly installs the packages for the primary (packit generated) COPR, but not the ones for all the other test plans. This led to cockpit-system and friends not being installed when running cockpit as reverse depedency gating test in PRs of other projects. Do what we already do in c-podman etc. and declare our own dependencies properly. They were dropped in commit 9877d51, but the reason is obsolete: TF will now go out of its way to upgrade/downgrade packages to the versions in the COPR, and even validate their versions.
martinpitt
added
the
no-test
This was referenced Aug 2, 2023
jelly
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tmt implicitly installs the packages for the primary (packit generated) COPR, but not the ones for all the other test plans. This led to cockpit-system and friends not being installed when running cockpit as reverse depedency gating test in PRs of other projects.
Do what we already do in c-podman etc. and declare our own dependencies properly. They were dropped in commit 9877d51, but the reason is obsolete: TF will now go out of its way to upgrade/downgrade packages to the versions in the COPR, and even validate their versions.
This broke running our tests in udisks and selinux-policy. I validated that this works in martinpitt/selinux-policy#2, the test passes now.