ci: Packit: Run cockpit storage tests in PRs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unconditionally define the various *_in_files, so that they appear in `make dist` tarballs independent of the configure options (in particular, `--disable-daemon`).
Configure with minimal options, so that we can build a dist tarball without too many extra dependencies. In particular, we want to avoid libblockdev, as we usually need the latest upstream master one, not the distro package.
martinpitt
force-pushed
the
run-cockpit-storage
branch
from
2026684
to
cd39cb5
Compare
martinpitt
force-pushed
the
run-cockpit-storage
branch
from
cd39cb5
to
4aa505f
Compare
|
@thrix, @happz: The -revdeps test for Fedora 38 fails to install because it doesn't see the libblockdev* packages from the @storage/udisks-daily COPR. I did add that to the .packit.yaml here: - type: repository-file
id: https://copr.fedorainfracloud.org/coprs/g/storage/udisks-daily/repo/fedora-$releasever/group_storage-udisks-daily-fedora-$releasever.repoin exactly the same way that I add the cockpit "main-builds" COPR. This is plumbed through via {
"id": "15a73f7f-1b28-41a6-9de0-6b09d75c3758",
"environments_requested": [
{
"artifacts": [
{
"id": "https://copr.fedorainfracloud.org/coprs/g/cockpit/main-builds/repo/fedora-$releasever/group_cockpit-main-builds-fedora-$releasever.repo",
"packages": null,
"type": "repository-file"
},
{
"id": "https://copr.fedorainfracloud.org/coprs/g/storage/udisks-daily/repo/fedora-$releasever/group_storage-udisks-daily-fedora-$releasever.repo",
"packages": null,
"type": "repository-file"
}
]
[...]
}Do you know what's wrong here? Thanks! |
|
Rawhide got a little further , but only because the install-packages step grabs libblockdev* from rawhide instead of the udisks-daily COPR. |
ci: Add Packit configuration for RPM builds on PRs
martinpitt
force-pushed
the
run-cockpit-storage
branch
from
ba256e1
to
b96740b
Compare
|
the deployment was outdated, now it should work as designed |
|
/packit test |
|
Amazing, it works perfectly. Many thanks @thrix! I close this now and open a PR against the real udisks project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://cockpit-project.org/blog/tmt-cross-project-testing.html