Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfixes #67

Merged
merged 3 commits into from
Jul 16, 2017
Merged

Devfixes #67

merged 3 commits into from
Jul 16, 2017

Conversation

bbkiwi
Copy link
Contributor

@bbkiwi bbkiwi commented Jul 16, 2017

Hi Charles,

These changes fix the issue #66 esp82xx and colorchord issues 45 and 46.

As we discussed then, some fix bugs that are part of esp82xx
The rest fix the bugs that appear when using esp82xx with colorchord.
These are fixed by more calls to EnterCritical() and ExitCritical().
(so using esp82xx in other situations when the above routines do nothing wont mess things up)
However, a refactoring will be due as the naming them Enter and Exit Critical is a bit misleading, as for colorchord it is a way to ensure the HPATimer is off at the right time.

Added EnterCritical() and ExitCritical() to ensure that ADC is not
   running when it will interfer with connection to station, and
   other routines.
TODO a better way would be to have flags set when ADC should not
   be running have one timed task turn it on or off.
Together with the fixes for colorchord/fixes the following work
1. Can switch between different stations and AP without rebooting
   issues (mostly).
2. Can scan for wifi when in AP mode and will return to AP afterwards
3. GPIO00 will restore to default AP from both AP or Station mode
4. Name of AP now terminated with 0
@con-f-use con-f-use merged commit 5f72094 into cnlohr:dev Jul 16, 2017
@cnlohr
Copy link
Owner

cnlohr commented Jul 19, 2017

This is some good stuff!

@cnlohr
Copy link
Owner

cnlohr commented Jul 19, 2017

I'm learning so much about the problems I left long ago.

con-f-use pushed a commit that referenced this pull request Jul 25, 2017
Squashed commit of the following:

commit 7bbbfa3
Merge: 5f72094 7a9ddd6
Author: con-f-use <[email protected]>
Date:   Sat Jul 22 07:59:06 2017 +0200

    Merge pull request #69 from bbkiwi/devpull

    Fix issue #68 where netburn was broken

commit 7a9ddd6
Author: bbkiwi <[email protected]>
Date:   Sat Jul 22 17:51:11 2017 +1200

    Fix bug that -DQUIET_REFLASH didn't work

commit 57264a0
Author: bbkiwi <[email protected]>
Date:   Sat Jul 22 15:59:34 2017 +1200

    Fix issue #68 where netburn was broken
    (found by finding code commit where bug began)

commit 5f72094
Merge: 2fb02df c0fc3a4
Author: con-f-use <[email protected]>
Date:   Sun Jul 16 16:03:06 2017 +0200

    Merge pull request #67 from bbkiwi/devfixes

    Devfixes

commit c0fc3a4
Author: bbkiwi <[email protected]>
Date:   Mon Jul 17 01:05:03 2017 +1200

    Changes needed to make esp82xx interact properly with colorchord
    Added EnterCritical() and ExitCritical() to ensure that ADC is not
       running when it will interfer with connection to station, and
       other routines.
    TODO a better way would be to have flags set when ADC should not
       be running have one timed task turn it on or off.
    Together with the fixes for colorchord/fixes the following work
    1. Can switch between different stations and AP without rebooting
       issues (mostly).
    2. Can scan for wifi when in AP mode and will return to AP afterwards
    3. GPIO00 will restore to default AP from both AP or Station mode
    4. Name of AP now terminated with 0

commit 6317698
Merge: 6a89fdc 2fb02df
Author: bbkiwi <[email protected]>
Date:   Mon Jul 10 14:29:22 2017 +1200

    Merge branch 'dev' of https://github.com/cnlohr/esp82xx into dev

commit 2fb02df
Author: con-f-use <[email protected]>
Date:   Sun Jun 25 11:12:57 2017 +0200

    Fetch toolchain automatically if missing

commit 21e23b5
Author: cnlohr <[email protected]>
Date:   Wed Jun 21 23:13:42 2017 -0400

    Tweaks to use less space.

commit 50afc5e
Merge: 9641825 adb21e5
Author: con-f-use <[email protected]>
Date:   Tue Jun 20 06:59:38 2017 +0200

    Merge pull request #63 from king2/dev

    Fix OTA upgrade bug and repair saving WiFi credentials

commit adb21e5
Author: king2 <[email protected]>
Date:   Tue Jun 20 01:10:03 2017 +0300

    Fix OTA upgrade bug and repair saving WiFi credentials

    1. removed skipping one byte from firmware sent by web
    2. size of flash chip now not hardcoded, will be restored correctly, so system parameters will be saved for all flash sizes, not only for 512K

commit 9641825
Author: con-f-use <[email protected]>
Date:   Mon Jun 19 21:48:57 2017 +0200

    Properly write flash (fix issue #61)

commit 79ce49d
Author: CNLohr <[email protected]>
Date:   Tue May 23 13:07:59 2017 -0400

    Update README.md

commit 6053b2f
Author: cnlohr <[email protected]>
Date:   Mon May 22 23:00:58 2017 -0400

    Put the strup function in flash.

commit 6a89fdc
Author: bbkiwi <[email protected]>
Date:   Tue May 23 14:47:08 2017 +1200

     Make date in VSTRING Mac-compatible (closes #50)

commit b26af31
Author: con-f-use <[email protected]>
Date:   Sat May 20 19:37:02 2017 +0200

    Make date in VSTRING Mac-compatible (closes #50)

commit b40da37
Merge: c65a641 6bc091d
Author: con-f-use <[email protected]>
Date:   Sat May 20 13:08:03 2017 +0200

    Merge pull request #59 from bbkiwi/dev

    Fixed typo of typo fix :-)

commit 6bc091d
Author: bbkiwi <[email protected]>
Date:   Sat May 20 22:57:23 2017 +1200

    Fixed typo of typo fix :-)

commit c65a641
Author: con-f-use <[email protected]>
Date:   Sat May 20 12:06:41 2017 +0200

    Typo in README.md regarding default IP (missed one)

commit 48405bf
Author: con-f-use <[email protected]>
Date:   Sat May 20 11:50:30 2017 +0200

    Minor typos in README.md - Thanks to @bbkiwi

commit 4d60955
Author: Jan Christoph Bischko <[email protected]>
Date:   Thu May 18 16:43:28 2017 +0200

    Document init-data in README.md

commit 88777be
Author: con-f-use <[email protected]>
Date:   Wed May 17 10:58:16 2017 +0200

    USe esp82xx version if top-level not a git project

commit b477734
Author: cnlohr <[email protected]>
Date:   Tue May 16 21:31:47 2017 -0400

    Closes #13 - Add support by switching protocol to binary and providing most users in Javascript space the same string, though the binary blob is also now available.

commit 860a50b
Author: con-f-use <[email protected]>
Date:   Tue May 16 13:07:35 2017 +0200

    Add features to allow for full flash erase and provide init_data for both regular ADC and ADC33. Also, cleanup location of some functions in main.

commit dc9f000
Merge: 85bf4a2 93074f1
Author: con-f-use <[email protected]>
Date:   Tue May 16 12:53:34 2017 +0200

    Level with master

commit 85bf4a2
Author: con-f-use <[email protected]>
Date:   Fri May 12 22:19:51 2017 +0200

    Fix typo in README.md

commit ef8aeee
Author: con-f-use <[email protected]>
Date:   Fri May 12 22:12:04 2017 +0200

    Document commands in `./commonsercies.c`

commit b7abbc1
Author: con-f-use <[email protected]>
Date:   Fri May 12 16:46:06 2017 +0200

    Minor updates to the readme

    Documentation of the commands in `./fwsrc/commonservies.c` still to come

commit 1885b4b
Merge: 86d0001 c159a6f
Author: con-f-use <[email protected]>
Date:   Thu Apr 6 18:23:45 2017 +0200

    Merge pull request #49 from temoto/patch-2

    readme: typos

commit c159a6f
Author: Sergey Shepelev <[email protected]>
Date:   Thu Apr 6 19:12:35 2017 +0300

    readme: typos

commit 86d0001
Author: con-f-use <[email protected]>
Date:   Fri Mar 3 19:09:09 2017 +0100

    Add sdk, 'make gitproject', inprove 'make project'

    Squashed commit of the following:

    commit 39574c3
    Author: con-f-use <[email protected]>
    Date:   Fri Mar 3 14:37:31 2017 +0100

        Add recursive pulling to README

    commit fe86201
    Author: con-f-use <[email protected]>
    Date:   Fri Mar 3 14:33:21 2017 +0100

        Small cleanups

    commit a77ffd9
    Author: con-f-use <[email protected]>
    Date:   Fri Mar 3 13:40:41 2017 +0100

        Fix them separators

        Makefiles...

    commit 50c1085
    Author: con-f-use <[email protected]>
    Date:   Fri Mar 3 13:25:31 2017 +0100

        Do not require Bash shell

    commit 96f5c52
    Author: con-f-use <[email protected]>
    Date:   Thu Mar 2 12:44:01 2017 +0100

        Add 'make gitproject' and reflect changes in readme

        Needs to be tested!
        Also added the sdk as a submodule. Still need to change paths in the makefiles and test it.

        DO NOT USE THIS COMMIT

commit 372ef87
Author: CNLohr <[email protected]>
Date:   Sat Feb 18 18:45:03 2017 -0500

    Update user_main.c

    Use recommended setup for cal flash map.

commit 72e18f5
Author: con-f-use <[email protected]>
Date:   Thu Feb 16 21:14:17 2017 +0100

    Add missing 'user_rf_cal_sector_set()'

commit fccd594
Author: con-f-use <[email protected]>
Date:   Thu Feb 16 21:02:36 2017 +0100

    Fix minor error cleaning rules

commit 5b4e57f
Author: con-f-use <[email protected]>
Date:   Mon Feb 6 15:19:04 2017 +0100

    Start a new project via `make project`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants