update GCT eg and hadronic cluster interface to Correlator

[skkwan]

PR description:

This PR includes:

• Fixes a missing half-crystal offset in the existing realEta() and realPhi() methods of the digitized clusters DataFormats/L1TCalorimeterPhase2/interface/DigitizedClusterCorrelator.h, so that there is an exact match with the real eta/phi returned by the float clusters.
• Adds new dataformats DataFormats/L1TCalorimeterPhase2/interface/GCTEmDigiCluster.h and DataFormats/L1TCalorimeterPhase2/interface/GCTHadDigiCluster.h, which represent the containerized outputs of the GCT barrel to the Correlator Layer 1 (see these slides for schematics). GCTEmDigiCluster.h is built from the digitized EM outputs of the GCT barrel emulator (DigitizedClusterCorrelator.h). GCTHadDigiCluster.h is built directly from the float outputs (EM + hadronic deposits) of the GCT PF Cluster emulator.
• The containers (std::vector<std::vector<>>) of the digitized clusters reflects the link structure to the Correlator Layer 1. Clusters are zero-padded (see these slides for schematics).
• The digitized clusters also contain edm::Ref to their parent clusters.

Note that this will affect the ParticleFlow code since the inputs are renamed; this has been agreed upon to be changed in a separate PR since the changes to the ParticleFlow code will need to be validated separately.

PR validation:

• An analyzer was used to check that the containerized digitized clusters can be read out and give the exact same real eta/phi location as the previous outputs. The edm::Ref to the parent clusters (for non-null clusters) has also been checked
• scram b code-format, scram build code-checks

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47193/43444

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47193/43444/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47193/43444/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47193/43445

[cmsbuild]

A new Pull Request was created by @skkwan for master.

It involves the following packages:

• DataFormats/L1TCalorimeterPhase2 (l1, upgrade)
• L1Trigger/L1CaloTrigger (l1, upgrade)

@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here