Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GCT eg and hadronic cluster interface to Correlator #131

Open
wants to merge 1 commit into
base: L1PF_14_2_X
Choose a base branch
from

Conversation

skkwan
Copy link

@skkwan skkwan commented Jan 28, 2025

PR description:

This PR corresponds to cms-sw#47193 and includes:

  • Fixes a missing half-crystal offset in the existing realEta() and realPhi() methods of the digitized clusters DataFormats/L1TCalorimeterPhase2/interface/DigitizedClusterCorrelator.h, so that there is an exact match with the real eta/phi returned by the float clusters.
  • Adds new dataformats DataFormats/L1TCalorimeterPhase2/interface/GCTEmDigiCluster.h and DataFormats/L1TCalorimeterPhase2/interface/GCTHadDigiCluster.h, which represent the containerized outputs of the GCT barrel to the Correlator Layer 1 (see these slides for schematics). GCTEmDigiCluster.h is built from the digitized EM outputs of the GCT barrel emulator (DigitizedClusterCorrelator.h). GCTHadDigiCluster.h is built directly from the float outputs (EM + hadronic deposits) of the GCT PF Cluster emulator.
  • The containers (std::vector<std::vector<>>) of the digitized clusters reflects the link structure to the Correlator Layer 1. Clusters are zero-padded (see these slides for schematics).
  • The digitized clusters also contain edm::Ref to their parent clusters.

Note that this will affect the ParticleFlow code since the inputs are renamed; this has been agreed upon to be changed in a separate PR since the changes to the ParticleFlow code will need to be validated separately.

PR validation:

  • An analyzer was used to check that the containerized digitized clusters can be read out and give the exact same real eta/phi location as the previous outputs. The edm::Ref to the parent clusters (for non-null clusters) has also been checked
  • scram b code-format, scram build code-checks

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant