-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search.gov Suggested Updates #467
Search.gov Suggested Updates #467
Conversation
- updated USWDS version for compatibility - updated Search.gov instructional comments - added typeahead functionality to search bar - removed site description as the meta description fallback - fixed text highlighting in title & snippet for search results - added robots.txt - added sitemap plugin (needs work)
document.body.appendChild(config); | ||
|
||
const src="https://search.usa.gov/javascripts/remote.loader.js"; | ||
const onLoad = () => console.log("Typeahead suggestions loaded."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need anything to happen onLoad, but I put this in as a placeholder. Feel free to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Amani, a few tweaks please. Thanks!
Thanks @amanifarooque - I would add that the big commercial engines also trigger off of lastmod dates in sitemaps, so it will be win-win to have those in the standard sitemap. |
Closed via #475, thanks @amanifarooque and @dawnpm! |
Thank you @hursey013! The two outstanding items that I couldn't figure out were:
Should I open issues for these? |
@amanifarooque apologies, I missed your notes about the sitemap - yes, if you don't mind creating an issue with some additional detail I'd be glad to take a look at it! |
Hi team,
We made a few suggested changes that were incorporated into the Jekyll template (cloud-gov/pages-uswds-jekyll#205), so we wanted to ensure they were also present in the Gatsby template for ease of use. I'm much less familiar with Gatsby/React, so please feel free to change the implementation as you see fit. We're hoping that with these changes, sites will be better set up for Search.gov indexing and display of search results.
Summary of Changes
Please reach out with any questions - also happy to meet if that's easier!