Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, address breaking USWDS change #474

Merged
merged 3 commits into from
Mar 10, 2022
Merged

Conversation

hursey013
Copy link
Contributor

@hursey013 hursey013 commented Mar 10, 2022

Update dependencies to pull in latest USWDS, fixing the specified breaking change.

When I did a fresh install of this repo in order to rebase #467, I noticed USWDS was not building correctly. Updating USWDS led to several other required updates, including replacing node-sass with sass (which is the culprit of numerous snyk/dependabot PRs), so I went ahead and updated everything and fixed the different breaking changes specified by the Gatsby/USWDS docs.

@hursey013 hursey013 requested a review from a team March 10, 2022 17:31
@hursey013 hursey013 marked this pull request as draft March 10, 2022 17:54
@hursey013 hursey013 marked this pull request as draft March 10, 2022 17:54
@hursey013
Copy link
Contributor Author

Working through an issue that seems to stem from remark-mdx...

@hursey013 hursey013 marked this pull request as ready for review March 10, 2022 19:47
@hursey013
Copy link
Contributor Author

@18F/federalist-admins ready for another look 👀

Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hursey013 hursey013 merged commit 7e11fbf into main Mar 10, 2022
@hursey013 hursey013 deleted the bh-update-deps branch March 10, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants