Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect screenshots in the README.md #1960

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix incorrect screenshots in the README.md #1960

merged 1 commit into from
Jan 23, 2025

Conversation

hanizang77
Copy link
Contributor

  • Update screenshots to align with the changed directory tree for initialization scripts

@hanizang77
Fix incorrect screenshots in the README.md
15c6ecc 
* Update screenshots to align with the changed directory tree for initialization scripts
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 23, 2025
yunkon-kim
yunkon-kim approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @hanizang77

@seokho-son
Copy link
Member

Hi @hanizang77
Thank you for the contribution~! :)

LGTM!

@yunkon-kim yunkon-kim merged commit 4e3ecbc into cloud-barista:main Jan 23, 2025
3 checks passed
@seokho-son
Copy link
Member

ref #1877

@hanizang77 hanizang77 deleted the 250123-11 branch January 23, 2025 02:58
@seokho-son
Copy link
Member

@hanizang77 (@yunkon-kim )
I believe there's room to further improve the screenshots.

The init/encCredential.sh and init/decCredential.sh scripts offer two options:

  1. Using a user-provided password
  2. Using a generated encryption key file (a more secure method)

The current PR only covers the first option.
I suggest we also include an explanation (and screenshot) of the second option. Feel free to continue contribution on this matter. :)

@hanizang77 hanizang77 mentioned this pull request Jan 24, 2025
Closed
hanizang77 added a commit to hanizang77/cb-tumblebug that referenced this pull request Jan 24, 2025
@hanizang77
Add screenshots in the README.md (feedback from cloud-barista#1960)
6c25a1a 
Add screenshots of using a generated encryption key file for the credential file
@hanizang77
Copy link
Contributor Author

Screenshots have been added in [commit 6c25a1a]. Please check the updated README.md.

@yunkon-kim
Copy link
Member

Hi, @hanizang77

Thank you for your contribution!

Could you please open your contribution as a separate PR? :)

@hanizang77 hanizang77 mentioned this pull request Jan 24, 2025
Merged
hanizang77 added a commit to hanizang77/cb-tumblebug that referenced this pull request Jan 24, 2025
@hanizang77
Change instructions in the README.md
ce9025c 
Update suggestions of @yunkon-kim to README.md
with additional text for each option number

Ref: cloud-barista#1960
@yunkon-kim yunkon-kim mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunkon-kim yunkon-kim yunkon-kim approved these changes

@seokho-son seokho-son Awaiting requested review from seokho-son seokho-son is a code owner

@sykim-etri sykim-etri Awaiting requested review from sykim-etri sykim-etri is a code owner

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanizang77 @seokho-son @yunkon-kim @dongjae