Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots in the README.md #1962

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

hanizang77
Copy link
Contributor

Add screenshots of using a generated encryption key file for the credential file

Ref: #1960

Add screenshots of using a generated encryption key file for the credential file
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 24, 2025
Copy link
Member

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanizang77 Thank you for this additional contribution!

I have a comment to show the two options clearly. Please check the suggestions and make any necessary improvements :-)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Update suggestions of @yunkon-kim to README.md
with additional text for each option number

Ref: cloud-barista#1960
Copy link
Member

@yunkon-kim yunkon-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @hanizang77

@yunkon-kim yunkon-kim merged commit e7c4d66 into cloud-barista:main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants