Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add aria-label to <a> elements #105

Merged
merged 1 commit into from
Aug 29, 2023
Merged

fix: add aria-label to <a> elements #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Pages/InteractiveMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,27 +54,31 @@ const InteractiveMap = () => {
href="https://github.com/chihacknight/breakout-groups/issues/217"
target="_blank"
rel="noreferrer"
aria-label="Breakout group information link"
>
<button className="action-btn">Breakout group information</button>
</a>
<a
href="https://github.com/chihacknight/ghost-buses-frontend"
target="_blank"
rel="noreferrer"
aria-label="Frontend Repository link"
>
<button className="action-btn">Frontend Repository</button>
</a>
<a
href="https://github.com/chihacknight/chn-ghost-buses/"
target="_blank"
rel="noreferrer"
aria-label="Data Repository link"
>
<button className="action-btn">Data Repository</button>
</a>
<a
href="https://twitter.com/ghostbuses"
target="_blank"
rel="noreferrer"
aria-label="Ghost Buses Twitter link"
>
<button className="action-btn">Ghost Bus Twitter</button>
</a>
Expand Down
16 changes: 12 additions & 4 deletions src/components/Socials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,28 @@
import React from "react";


export default function Socials() {
return (
<div className="social-sidebar">
<a href="https://twitter.com/ghostbuses">
<a
href="https://twitter.com/ghostbuses"
aria-label="Ghost Buses Twitter link"
>
<div className="social-icon twitter">
<i className="fa-brands fa-twitter"></i>
</div>
</a>
<a href="https://github.com/chihacknight/chn-ghost-buses">
<a
href="https://github.com/chihacknight/chn-ghost-buses"
aria-label="Ghost Buses GitHub link"
>
<div className="social-icon github">
<i className="fa-brands fa-github"></i>
</div>
</a>
<a href="https://chihacknight.org/">
<a
href="https://chihacknight.org/"
aria-label="Chi Hack Night website link"
>
<div className="social-icon chn">
<svg
version="1.0"
Expand Down