Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add aria-label to <a> elements #105

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

jae-the-castaway
Copy link
Contributor

Description

This PR is being opened to merge into dev branch. This fixes the links without a discernible text. I added aria-label attributes.

It will close the issue #90, when approved.

Checklist

  • I am requesting to merge into the main branch
  • I have performed a self-review of my code

Screenshots

Screenshot of light house test

This is a screenshot of the Lighthouse Test.

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for creative-quokka-61f1f5 ready!

Name Link
🔨 Latest commit 3ad28cb
🔍 Latest deploy log https://app.netlify.com/sites/creative-quokka-61f1f5/deploys/64ea38888b538b00087ac663
😎 Deploy Preview https://deploy-preview-105--creative-quokka-61f1f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for sprightly-muffin-751ffc ready!

Name Link
🔨 Latest commit 3ad28cb
🔍 Latest deploy log https://app.netlify.com/sites/sprightly-muffin-751ffc/deploys/64ea3888299c070007999942
😎 Deploy Preview https://deploy-preview-105--sprightly-muffin-751ffc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hkier hkier self-requested a review August 29, 2023 19:47
@hkier hkier merged commit 5159e95 into chihacknight:main Aug 29, 2023
@hkier
Copy link
Collaborator

hkier commented Aug 29, 2023

I am approving and merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants