Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mail api url to config #499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added mail api url to config #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ env = [
"FS_UPLOAD_CONFIG__ROOT=../upload",
"FS_UPLOAD_CONFIG__MKDIR=true",
"FS_DOWNLOAD_CONFIG__PROTOCOL=file",
"ENV=TEST"
"ENV=TEST",
"MAIL_API_URL=http://mail-api:8765/internal/confirmation/send"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with MAIL_API added to sbl-project. Will need to either update that one to MAIL_API_URL, or change these to MAIL_API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like MAIL_API_URL, thinking about it. I'll update my stories for the helm charts, do you want to create a new story and fix it in sbl-project since I already approved and merged there (hadn't looked at these yet).

My bad, didn't keep consistent myself between stories. So let's go with this since filing-api is the one using it and everything will be done with this PR then.

]
testpaths = ["tests"]

Expand Down
3 changes: 2 additions & 1 deletion src/.env.local
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ JWT_OPTS_VERIFY_ISS="false"
FS_UPLOAD_CONFIG__PROTOCOL="file"
FS_UPLOAD_CONFIG__ROOT="../upload"
EXPIRED_SUBMISSION_CHECK_SECS=120
SERVER_CONFIG__RELOAD="true"
SERVER_CONFIG__RELOAD="true"
MAIL_API_URL=http://mail-api:8765/internal/confirmation/send
1 change: 1 addition & 0 deletions src/sbl_filing_api/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ class Settings(BaseSettings):
expired_submission_check_secs: int = 120

user_fi_api_url: str = "http://sbl-project-user_fi-1:8888/v1/institutions/"
mail_api_url: str = "http://mail-api:8765/internal/confirmation/send"

max_validation_errors: int = 1000000
max_json_records: int = 10000
Expand Down
5 changes: 5 additions & 0 deletions tests/app/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,8 @@ def test_default_server_configs():
assert settings.server_config.reload is False
assert settings.server_config.time_out == 65
assert settings.server_config.port == 8888


def test_url_configs():
settings = Settings()
assert settings.mail_api_url == "http://mail-api:8765/internal/confirmation/send"
Loading