Added mail api url to config #499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
jcadam14
reviewed
Nov 15, 2024
| @@ -77,7 +77,8 @@ env = [ | |||
| "FS_UPLOAD_CONFIG__ROOT=../upload", | |||
| "FS_UPLOAD_CONFIG__MKDIR=true", | |||
| "FS_DOWNLOAD_CONFIG__PROTOCOL=file", | |||
| "ENV=TEST" | |||
| "ENV=TEST", | |||
| "MAIL_API_URL=http://mail-api:8765/internal/confirmation/send" | |||
There was a problem hiding this comment.
This conflicts with MAIL_API added to sbl-project. Will need to either update that one to MAIL_API_URL, or change these to MAIL_API.
There was a problem hiding this comment.
I like MAIL_API_URL, thinking about it. I'll update my stories for the helm charts, do you want to create a new story and fix it in sbl-project since I already approved and merged there (hadn't looked at these yet).
My bad, didn't keep consistent myself between stories. So let's go with this since filing-api is the one using it and everything will be done with this PR then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #494