Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pool QA #2563

Merged
merged 15 commits into from
Jan 20, 2025
Merged

Create pool QA #2563

merged 15 commits into from
Jan 20, 2025

Conversation

kattylucy
Copy link
Collaborator

@kattylucy kattylucy commented Dec 19, 2024 •
edited
Loading

  • Make page scroll to top after clicking next step
  • Make target default value for APY
  • Add please select as a value on dropdown

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2563-app-ff-production.k-f.dev
Commit #: c6eadd7
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2563.k-f.dev
Commit #: c6eadd7
To access the functions directly check the corresponding deploy Action

@kattylucy kattylucy force-pushed the create_pool branch 2 times, most recently from 4b488c9 to c7c2295 Compare January 8, 2025 11:48
sophialittlejohn
sophialittlejohn reviewed Jan 17, 2025
View reviewed changes
centrifuge-app/src/pages/IssuerCreatePool/validate.ts Outdated
@@ -114,6 +114,17 @@ export const validateValues = (values: CreatePoolValues) => {
})
}

if (values.issuerCategories.length > 1) {
values.issuerCategories.forEach((category, i) => {
if (category.type == '') {
Copy link
Collaborator

@sophialittlejohn sophialittlejohn Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the warnings!

sophialittlejohn
sophialittlejohn approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Please address at minimum the warnings I comment on below before merging!

@kattylucy kattylucy merged commit 001f3df into main Jan 20, 2025
13 checks passed
@kattylucy kattylucy deleted the create_pool branch January 20, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophialittlejohn sophialittlejohn sophialittlejohn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattylucy @sophialittlejohn