Fix linter warnings

centrifuge · Jan 20, 2025 · e25c3d8 · e25c3d8
1 parent ea000a5
commit e25c3d8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 22 deletions.
diff --git a/centrifuge-app/src/pages/IssuerCreatePool/PoolSetupSection.tsx b/centrifuge-app/src/pages/IssuerCreatePool/PoolSetupSection.tsx
@@ -74,7 +74,7 @@ export const PoolSetupSection = () => {
 
   useEffect(() => {
     form.setFieldValue('adminMultisig.signers[0]', substrate.selectedAddress)
-  }, [substrate])
+  }, [substrate, form])
 
   return (
     <Box>
@@ -297,7 +297,7 @@ export const PoolSetupSection = () => {
         {({ push, remove }) => (
           <>
             {values.poolFees.map((_, index) => {
-              if (index === 0) return
+              if (index === 0) return null
               return (
                 <Box mt={4} mb={3} key={index}>
                   <StyledGrid mt={3} gap={1}>

diff --git a/centrifuge-app/src/pages/IssuerCreatePool/index.tsx b/centrifuge-app/src/pages/IssuerCreatePool/index.tsx
@@ -15,7 +15,7 @@ import { Box, Button, Dialog, Step, Stepper, Text } from '@centrifuge/fabric'
 import { createKeyMulti, sortAddresses } from '@polkadot/util-crypto'
 import BN from 'bn.js'
 import { Form, FormikProvider, useFormik } from 'formik'
-import { useEffect, useRef, useState } from 'react'
+import { useCallback, useEffect, useRef, useState } from 'react'
 import { useNavigate } from 'react-router'
 import { combineLatest, firstValueFrom, switchMap, tap } from 'rxjs'
 import styled, { useTheme } from 'styled-components'
@@ -128,7 +128,7 @@ const IssuerCreatePoolPage = () => {
       // It can take a second for the new data to come in after creating the pool
       navigate(`/issuer/${poolId}`)
     }
-  }, [poolId, pools])
+  }, [poolId, pools, navigate])
 
   const { execute: createProxies, isLoading: createProxiesIsPending } = useCentrifugeTransaction(
     `${txMessage[createType]} 1/2`,
@@ -427,32 +427,35 @@ const IssuerCreatePoolPage = () => {
 
   const { values, errors } = form
 
-  const checkStepCompletion = (stepNumber: number) => {
-    const fields = stepFields[stepNumber]
+  const checkStepCompletion = useCallback(
+    (stepNumber: number) => {
+      const fields = stepFields[stepNumber]
 
-    let isValid = fields.every((field) => {
-      const value = values[field as keyof typeof values]
-      const error = errors[field as keyof typeof errors]
-      return value !== null && value !== '' && !error
-    })
+      let isValid = fields.every((field) => {
+        const value = values[field as keyof typeof values]
+        const error = errors[field as keyof typeof errors]
+        return value !== null && value !== '' && !error
+      })
 
-    if (values.issuerCategories.length > 1 && errors.issuerCategories) {
-      isValid = false
-    }
+      if (values.issuerCategories.length > 1 && errors.issuerCategories) {
+        isValid = false
+      }
 
-    if (values.poolRatings.length > 1 && errors.poolRatings) {
-      isValid = false
-    }
+      if (values.poolRatings.length > 1 && errors.poolRatings) {
+        isValid = false
+      }
 
-    return isValid
-  }
+      return isValid
+    },
+    [values, errors]
+  )
 
   useEffect(() => {
     setStepCompleted((prev) => ({
       ...prev,
       [step]: checkStepCompletion(step),
     }))
-  }, [values, errors, step, stepFields])
+  }, [values, errors, step, checkStepCompletion])
 
   useEffect(() => {
     if (containerRef.current) {

diff --git a/centrifuge-app/src/pages/IssuerCreatePool/validate.ts b/centrifuge-app/src/pages/IssuerCreatePool/validate.ts
@@ -116,10 +116,10 @@ export const validateValues = (values: CreatePoolValues) => {
 
   if (values.issuerCategories.length > 1) {
     values.issuerCategories.forEach((category, i) => {
-      if (category.type == '') {
+      if (category.type === '') {
         errors = setIn(errors, `issuerCategories.${i}.type`, 'Field is required')
       }
-      if (category.value == '') {
+      if (category.value === '') {
         errors = setIn(errors, `issuerCategories.${i}.value`, 'Field is required')
       }
     })