Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Parallel Deconvolution in Lollipop #166

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

gordonkoehn
Copy link
Contributor

@gordonkoehn gordonkoehn commented Oct 11, 2024

This PR enables parallel processing for Lollipop's deconvolution. The deconvolution can now be done in parallel for each location.

To consider:

  • Ensure correct Versioning of Lollipop
  • Adding a note in the V-Pipe Docs on the recommended number of cores for the deconvolution

@gordonkoehn gordonkoehn self-assigned this Oct 11, 2024
@gordonkoehn gordonkoehn changed the base branch from master to rubicon October 11, 2024 11:45
@gordonkoehn gordonkoehn marked this pull request as draft October 11, 2024 11:45
Copy link

github-actions bot commented Oct 11, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH shellcheck 11 0 0.53s
✅ DOCKERFILE hadolint 1 0 0.31s
✅ JUPYTER jupyfmt 11 8 0 7.41s
✅ MARKDOWN markdownlint 17 3 0 2.07s
✅ PERL perlcritic 1 0 0.95s
✅ PYTHON black 52 0 0 2.17s
✅ SNAKEMAKE snakefmt 25 2 0 11.31s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@gordonkoehn
Copy link
Contributor Author

gordonkoehn commented Oct 11, 2024

@DrYak Is there an appropriate place where I could document the recommended usage, i.e., the recommended number of threads for the deconvolution – should I ? - [DONE - see config_schema.json]

@gordonkoehn gordonkoehn force-pushed the feature-lollipop-deconv-parallel branch from 75eb8d1 to 59ce8c9 Compare October 11, 2024 18:03
@DrYak DrYak merged commit 59ce8c9 into rubicon Oct 12, 2024
25 of 29 checks passed
@gordonkoehn gordonkoehn deleted the feature-lollipop-deconv-parallel branch October 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants