charm logging lib #392
Merged
charm logging lib #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroPasotti
requested review from
Abuelodelanada,
dstathis,
IbraAoad,
lucabello,
mmkay,
sed-i and
simskij
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Note: this only works in combination with #394 |
sed-i
reviewed
May 3, 2024
dstathis
previously approved these changes
May 28, 2024
mmkay
approved these changes
May 31, 2024
|
tests will be broken until this merges and cosl is re-released |
…r into charm-logging
|
Waiting for cosl to release 0.0.12 |
sed-i
previously requested changes
Jun 6, 2024
sed-i
reviewed
Jun 17, 2024
sed-i
reviewed
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loki integration for charm logs.
waiting on canonical/cos-lib#26