Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public method to LogForwarder to retrieve the full endpoint urls #401

Open
PietroPasotti opened this issue May 21, 2024 · 1 comment

Comments

@PietroPasotti
Copy link
Contributor

we only have a private: _retrieve_endpoints_from_relation method.

To facilitate integration with e.g. charm logging utils, we should be able to access the endpoints from the parent object (the charm).

Originally posted by @Abuelodelanada in #392 (comment)

@lucabello
Copy link
Contributor

That function was intentionally made private because we didn't want charms to use that. We can go back on that decision, but I'd rather have an ADR on that to make sure the team's on the same page :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants