Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin charmcraft channel to 3.x/stable #565

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Sep 2, 2024

This PR is part of closing this issue.

It pins the channel used in our CI from latest/candidate to 3.x/stable.

Ideally we can unpin the version when this issue is fixed.

@mvlassis mvlassis requested a review from a team as a code owner September 2, 2024 11:09
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mvlassis, tiny nit.

.github/workflows/integrate.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvlassis mvlassis merged commit e3bdcdf into main Sep 4, 2024
51 checks passed
@mvlassis mvlassis deleted the kf-6195-pin-charmcraft-version branch September 4, 2024 09:19
@mvlassis mvlassis changed the title Pin charmcraft channel to 3.1/stable Pin charmcraft channel to 3.x/stable Sep 4, 2024
mvlassis added a commit that referenced this pull request Sep 4, 2024
* Pin charmcraft channel

* Update .github/workflows/integrate.yaml

Co-authored-by: Daniela Plascencia <[email protected]>

* Add comment above the pinning to link to the proper issue

* Pin to 3.x instead of 3.1 which doesn't exist as a track

---------

Co-authored-by: Daniela Plascencia <[email protected]>
mvlassis added a commit that referenced this pull request Sep 4, 2024
* Pin charmcraft channel

* Update .github/workflows/integrate.yaml

Co-authored-by: Daniela Plascencia <[email protected]>

* Add comment above the pinning to link to the proper issue

* Pin to 3.x instead of 3.1 which doesn't exist as a track

---------

Co-authored-by: Daniela Plascencia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants