Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport-2.0): Pin charmcraft channel to 3.x/stable #567

Merged

Conversation

mvlassis
Copy link
Contributor

@mvlassis mvlassis commented Sep 4, 2024

This PR is a backport of #565.

It is part of closing this issue.

It pins the channel used in our CI from latest/candidate to 3.x/stable.

Ideally we can unpin the version when this issue is fixed.

* Pin charmcraft channel

* Update .github/workflows/integrate.yaml

Co-authored-by: Daniela Plascencia <[email protected]>

* Add comment above the pinning to link to the proper issue

* Pin to 3.x instead of 3.1 which doesn't exist as a track

---------

Co-authored-by: Daniela Plascencia <[email protected]>
@mvlassis mvlassis requested a review from a team as a code owner September 4, 2024 12:34
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mvlassis . Let's ensure that the CI passes before merging. Also, let's use a merge commit since this is a backport.

@mvlassis mvlassis merged commit fdf5e49 into track/2.0 Sep 6, 2024
46 checks passed
@mvlassis mvlassis deleted the backport-track-2.0-kf-6195-pin-charmcraft-version branch September 6, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants