Update demo_ingress to expect a reads service name instead of managing services #1634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue that Phil ran into earlier this week after we rolled out reads using the new deployment methodology. Spinning up demos depended on being able to ask the k8s API what the current reads deployment was, and then generated a new Service object for you. Often times this just ended up being a new Service object called "gnomad-reads-demo-foobar" that pointed at the current production deployment pods, which didn't feel particularly useful.
I thought about this for a bit, and decided that managing the extra service object here was probably unnecessary? With these assumptions:
With those in mind, I've updated this script to just accept a reads Service name, and it uses that to configure the ingress instead of creating a bunch of extra Services. If you don't specify a service name, it just points /reads on your demo to the active prod service.
How do folks feel about that process, and are those assumptions I've made correct?