Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for demo deployments to optionally include the reads deployment #1342

Closed
Tracked by #1468
sjahl opened this issue Dec 5, 2023 · 0 comments · Fixed by #1634
Closed
Tracked by #1468

Allow for demo deployments to optionally include the reads deployment #1342

sjahl opened this issue Dec 5, 2023 · 0 comments · Fixed by #1634

Comments

@sjahl
Copy link
Contributor

sjahl commented Dec 5, 2023

It's now a common occurrence for us to be deploying browser demos on clusters that are not the production cluster. In many of these cases, there is no reads deployment, unless reads is the component that is being demoed. This creates friction when trying to create the demo ingress, since it expects there to be a reads service. The workaround is simply to attempt to create the ingress again, which works a second time, because the first attempt creates the (bogus) reads Service objects before it ultimately fails.

We should have an option in our demo ingress / kustomize config to only create the reads service when desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment