Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https://github.com/brisbanesocialchess/.github/issues/102 #103

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Fix https://github.com/brisbanesocialchess/.github/issues/102 #103

wants to merge 9 commits into from

Conversation

BaseMax
Copy link
Member

@BaseMax BaseMax commented Oct 31, 2024

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 31, 2024
@jbampton jbampton self-assigned this Oct 31, 2024
jbampton
jbampton reviewed Oct 31, 2024
View reviewed changes
profile/README.md Outdated
Comment on lines 35 to 37
<p align="center">
<a href="https://discord.com/invite/JWBKhQmzvD" style="text-decoration:none;">
<p align=center>
<a href="https://discord.com/invite/JWBKhQmzvD" style=text-decoration:none>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the quotes removed ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

profile/README.md:38:11: typography.symbols.curly_quotes Use curly quotes “”, not straight quotes "".
profile/README.md:40:142: typography.symbols.curly_quotes Use curly quotes “”, not straight quotes "".

@jbampton jbampton linked an issue Oct 31, 2024 that may be closed by this pull request
README issues #102
Closed
@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

Now it's ready for you, John.

@BaseMax BaseMax mentioned this pull request Oct 31, 2024
Closed
jbampton
jbampton requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML need to be valid with quotes.

So just use a proselint ignore in a config

@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

Will check that in next merge request.

@jbampton jbampton marked this pull request as draft October 31, 2024 23:44
@BaseMax
Copy link
Member Author

BaseMax commented Nov 1, 2024

This branch is out-of-date with the base branch
Merge the latest changes from main into this branch.

Update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbampton jbampton jbampton requested changes

Assignees

@jbampton jbampton

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest
Projects
Chess
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README issues
2 participants
@BaseMax @jbampton