Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README issues #102

Closed
BaseMax opened this issue Oct 31, 2024 · 10 comments · May be fixed by #103
Closed

README issues #102

BaseMax opened this issue Oct 31, 2024 · 10 comments · May be fixed by #103
Assignees
@BaseMax
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@BaseMax
Copy link
Member

BaseMax commented Oct 31, 2024 

Run proselint **/*.md
profile/README.md:5:53: leonard.exclamation.30ppm More than 30 ppm of exclamations. Keep them under control.
profile/README.md:13:40: typography.diacritical_marks Use diacritical marks in 'café'.
profile/README.md:15:4[7](https://github.com/brisbanesocialchess/.github/actions/runs/11611646504/job/32333433573#step:5:8): typography.diacritical_marks Use diacritical marks in 'café'.
profile/README.md:35:11: typography.symbols.curly_quotes Use curly quotes “”, not straight quotes "".
profile/README.md:37:142: typography.symbols.curly_quotes Use curly quotes “”, not straight quotes "".
profile/README.md:123:32: hyperbolic.misc '!!' is hyperbolic.
profile/README.md:123:33: leonard.exclamation.multiple Stop yelling. Keep your exclamation points under control.
Error: Process completed with exit code 1.
@jbampton jbampton added documentation Improvements or additions to documentation good first issue Good for newcomers labels Oct 31, 2024
@jbampton
Copy link
Member

I am not sure about all this

@jbampton
Copy link
Member

Maybe need a config file for proselint

@jbampton jbampton added help wanted Extra attention is needed hacktoberfest labels Oct 31, 2024
BaseMax added a commit to MaxFork/chess-john-aus.github that referenced this issue Oct 31, 2024
@BaseMax
Fix brisbanesocialchess#102
55cf073
@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

#102

@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024 

profile/README.md:5:53: leonard.exclamation.30ppm More than 30 ppm of exclamations. Keep them under control.
profile/README.md:3[8](https://github.com/brisbanesocialchess/.github/actions/runs/11611744759/job/32333734938?pr=103#step:5:9):142: typography.symbols.curly_quotes Use curly quotes “”, not straight quotes "".

@jbampton jbampton linked a pull request Oct 31, 2024 that will close this issue
Fix https://github.com/brisbanesocialchess/.github/issues/102 #103
Draft
@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024 

profile/README.md:44:176: leonard.exclamation.30ppm More than 30 ppm of exclamations. Keep them under control.

@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

Done

@BaseMax BaseMax closed this as completed Oct 31, 2024
@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

profile/README.md:104:35: leonard.exclamation.30ppm More than 30 ppm of exclamations. Keep them under control. fixed

@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

profile/README.md:126:31: leonard.exclamation.30ppm More than 30 ppm of exclamations. Keep them under control. again

@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

no errors
https://github.com/brisbanesocialchess/.github/actions/runs/11611889712/job/32334172572?pr=103

@BaseMax
Copy link
Member Author

BaseMax commented Oct 31, 2024

ready to merge #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BaseMax BaseMax

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
Chess
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix https://github.com/brisbanesocialchess/.github/issues/102 MaxFork/chess-john-aus.github
2 participants
@jbampton @BaseMax