Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pybind11 v2.13.1 #166

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Upgrade to pybind11 v2.13.1 #166

merged 2 commits into from
Jun 28, 2024

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Jun 28, 2024

This PR upgrades Pybind11 to version 2.13.1.
The main reason for this is to support numpy v2.0.0 which was recently released. Using an older version of pybind11 causes a segmentation fault when running the python tests.

NOTE: This should be an easy review since only the Pybind11 files are copied over from the latest release version.

Update: I fixed a bug in Pybind11 (see the PR) and instead of waiting for a new release, I made a similar fix here.

Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@varunagrawal varunagrawal merged commit 38a1bfa into master Jun 28, 2024
8 checks passed
@varunagrawal varunagrawal deleted the pybind-update branch June 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants