Additional Nonlinear CG Direction Methods #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll look at this after other PRs have been addressed. |
Base automatically changed from
conjugate-gradient-system
to
conjugate-gradient
October 16, 2024 14:21
|
Could you also template these in the same vein as Polak-Ribiere? The idea -as I remember it- is that CG does not need to know whether the underlying "system" is actually a dense, sparse, graph, or other system that has the right operators. I do regret that we did not add unit tests in that vein. |
Ah good catch. I'll do that right now. |
|
I still need to add some tests. Will do that later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added other direction methods for CG beyond Polak-Ribiere.