Use bundled pybind11 for Python wrapper
#1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding Fan as reviewer |
|
Also, CI fails :-( |
|
I'll kill all CI for this push... |
|
Did you try locally before pushing? |
|
Ah it's giving an error because we need to also point cmake to the Pybind11 directory so it can generate the pybind11Config.cmake file. Figuring that out. |
dellaert
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Yep, this fixed the segfaults I saw on my system ! Thanks @varunagrawal !!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force the use of the bundled
pybind11directory when compiling the Python wrapper.This should hopefully fix issues like in #1720.