Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GTSAM version setting #1626

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix GTSAM version setting #1626

merged 1 commit into from
Sep 5, 2023

Conversation

varunagrawal
Copy link
Collaborator

Update CMake to set the GTSAM version values correctly. Do the same for GTSAM_UNSTABLE.

For the current version 4.3.0, if GTSAM_PRERELEASE_VERSION is specified, e.g. "a0", the version string will be set to "4.3a0", otherwise it will be set to "4.3.0".

@varunagrawal varunagrawal added the cmake Related to CMake and build system label Sep 5, 2023
@varunagrawal varunagrawal self-assigned this Sep 5, 2023
@dellaert
Copy link
Member

dellaert commented Sep 5, 2023

Cool. How do you know it works?

@varunagrawal
Copy link
Collaborator Author

Cool. How do you know it works?

I built the python wheels locally in a docker container and was able to verify this was correct.

This issue only seems to affect the GTSAM_VERSION_STRING variable which is what is used to set the version in the gtsam python package (please refer to setup.py.in line 27).
Interestingly, downstream C++ projects (like GTD) use the version set in the project() cmake function, so CMake there would show GTSAM as 4.3.0 which is correct.

@varunagrawal varunagrawal merged commit 9cdf9ce into develop Sep 5, 2023
26 checks passed
@varunagrawal varunagrawal deleted the cmake-fix-version branch September 5, 2023 23:35
@varunagrawal varunagrawal restored the cmake-fix-version branch September 6, 2023 01:05
@varunagrawal varunagrawal deleted the cmake-fix-version branch September 6, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake and build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants