fixes issues with TBB not being found when building downstream packages #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nathanhhughes ! The package config files probably needs some care as CMake now have evolved so much... |
@ProfFan you made this comment but then did not approve PR. If you agree this is good (i did not check in detail), please approve and merge? |
varunagrawal
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
@nathanhhughes you may want to note that the latest versions of TBB have adopted a different versioning scheme that reflects the year of release. Other than that LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I noticed that #1567 broke downstream packages that build against GTSAM (e.g., Kimera-RPGO) as it switches to linking against TBB interface/alias libraries which aren't declared as a dependency. Regardless, TBB should probably be added via
find_dependencyin GTSAM's cmake config if it's being publicly linked against.This at least fixes the issue for me when TBB is found, but I'm not entirely sure if:
HandleTBB.cmakethat GTSAM's config could use