Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes issues with TBB not being found when building downstream packages #1587

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nathanhhughes
Copy link
Contributor

Hi! I noticed that #1567 broke downstream packages that build against GTSAM (e.g., Kimera-RPGO) as it switches to linking against TBB interface/alias libraries which aren't declared as a dependency. Regardless, TBB should probably be added via find_dependency in GTSAM's cmake config if it's being publicly linked against.

This at least fixes the issue for me when TBB is found, but I'm not entirely sure if:

  1. it would be preferable to have a TBB version set in HandleTBB.cmake that GTSAM's config could use
  2. this works when TBB isn't present on the system

@ProfFan
Copy link
Collaborator

ProfFan commented Jul 21, 2023

Thanks @nathanhhughes ! The package config files probably needs some care as CMake now have evolved so much...

@dellaert
Copy link
Member

Thanks @nathanhhughes ! The package config files probably needs some care as CMake now have evolved so much...

@ProfFan you made this comment but then did not approve PR. If you agree this is good (i did not check in detail), please approve and merge?

Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathanhhughes you may want to note that the latest versions of TBB have adopted a different versioning scheme that reflects the year of release. Other than that LGTM.

@varunagrawal varunagrawal merged commit 19c3939 into borglab:develop Jul 27, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants