Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some python and c++ examples with BinaryMeasurements #1583

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Added some python and c++ examples with BinaryMeasurements #1583

merged 1 commit into from
Jul 22, 2023

Conversation

dellaert
Copy link
Member

  • in response to GTSAM group question
  • also added a check on pMin, which segfaulted if pMin < d :-(

@dellaert dellaert requested a review from ProfFan July 19, 2023 11:12
varunagrawal
varunagrawal approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dellaert dellaert merged commit 1f0d318 into develop Jul 22, 2023
26 checks passed
@dellaert dellaert deleted the feature/shonan_examples branch July 22, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dellaert @varunagrawal