Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TableFactor Unary Apply Methods #1580

Merged
merged 2 commits into from
Jul 19, 2023
Merged

TableFactor Unary Apply Methods #1580

merged 2 commits into from
Jul 19, 2023

Conversation

varunagrawal
Copy link
Collaborator

  • Override unary apply methods for the TableFactor.
  • Improve TableFactor docstrings.

@varunagrawal varunagrawal self-assigned this Jul 17, 2023
@varunagrawal varunagrawal mentioned this pull request Jul 17, 2023
Merged
@dellaert
Copy link
Member

Why is base not develop?

@varunagrawal
Copy link
Collaborator Author

This PR builds upon other changes I made, and I broke it down into smaller PRs, hence the PR chaining.

Base automatically changed from hybrid-tablefactor-2 to develop July 19, 2023 10:42
@varunagrawal varunagrawal merged commit 0f7bc5c into develop Jul 19, 2023
26 checks passed
@varunagrawal varunagrawal deleted the tablefactor-apply branch July 19, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert