Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baddns logic bug #2145

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Fix baddns logic bug #2145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5803c51
baddns logic bug fix
liquidsec Jan 10, 2025
bee0d74
Merge branch 'dev' into baddns-logic-fix
liquidsec Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions bbot/modules/baddns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@ async def handle_event(self, event):
for r in results:
r_dict = r.to_dict()

if r_dict["confidence"] in ["CONFIRMED", "PROBABLE"]:
confidence = r_dict["confidence"]

if confidence in ["CONFIRMED", "PROBABLE"]:
data = {
"severity": "MEDIUM",
"description": f"{r_dict['description']}. Confidence: [{r_dict['confidence']}] Signature: [{r_dict['signature']}] Indicator: [{r_dict['indicator']}] Trigger: [{r_dict['trigger']}] baddns Module: [{r_dict['module']}]",
"description": f"{r_dict['description']}. Confidence: [{confidence}] Signature: [{r_dict['signature']}] Indicator: [{r_dict['indicator']}] Trigger: [{r_dict['trigger']}] baddns Module: [{r_dict['module']}]",
"host": str(event.host),
}
await self.emit_event(
Expand All @@ -101,20 +103,24 @@ async def handle_event(self, event):
context=f'{{module}}\'s "{r_dict["module"]}" module found {{event.type}}: {r_dict["description"]}',
)

elif r_dict["confidence"] in ["UNLIKELY", "POSSIBLE"] and not self.only_high_confidence:
data = {
"description": f"{r_dict['description']} Confidence: [{r_dict['confidence']}] Signature: [{r_dict['signature']}] Indicator: [{r_dict['indicator']}] Trigger: [{r_dict['trigger']}] baddns Module: [{r_dict['module']}]",
"host": str(event.host),
}
await self.emit_event(
data,
"FINDING",
event,
tags=[f"baddns-{module_instance.name.lower()}"],
context=f'{{module}}\'s "{r_dict["module"]}" module found {{event.type}}: {r_dict["description"]}',
)
elif confidence in ["UNLIKELY", "POSSIBLE"]:
if not self.only_high_confidence:
data = {
"description": f"{r_dict['description']} Confidence: [{confidence}] Signature: [{r_dict['signature']}] Indicator: [{r_dict['indicator']}] Trigger: [{r_dict['trigger']}] baddns Module: [{r_dict['module']}]",
"host": str(event.host),
}
await self.emit_event(
data,
"FINDING",
event,
tags=[f"baddns-{module_instance.name.lower()}"],
context=f'{{module}}\'s "{r_dict["module"]}" module found {{event.type}}: {r_dict["description"]}',
)
else:
self.debug(f"Skipping low-confidence result due to only_high_confidence setting: {confidence}")

else:
self.warning(f"Got unrecognized confidence level: {r_dict['confidence']}")
self.warning(f"Got unrecognized confidence level: {confidence}")

found_domains = r_dict.get("found_domains", None)
if found_domains:
Expand Down
Loading