Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baddns logic bug #2145

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Fix baddns logic bug #2145

merged 2 commits into from
Jan 12, 2025

Conversation

liquidsec
Copy link
Collaborator

Issue originally reported here: #2081

@liquidsec liquidsec mentioned this pull request Jan 10, 2025
@liquidsec liquidsec changed the title Fixing baddns logic bug Fix baddns logic bug Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (b33e384) to head (bee0d74).
Report is 17 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/modules/baddns.py 25% 6 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2145   +/-   ##
=====================================
- Coverage     93%     93%   -0%     
=====================================
  Files        372     372           
  Lines      28936   28939    +3     
=====================================
- Hits       26735   26724   -11     
- Misses      2201    2215   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liquidsec liquidsec merged commit 117ce88 into dev Jan 12, 2025
14 checks passed
@liquidsec liquidsec deleted the baddns-logic-fix branch January 12, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants