Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging < main #2966

Merged
merged 86 commits into from
Jun 17, 2024
Merged

Staging < main #2966

merged 86 commits into from
Jun 17, 2024

Commits on May 19, 2024

  1. LINT: Fix rubocop issue Layout/IndentationConsistency

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ed2427f View commit details
    Browse the repository at this point in the history

  2. Regenerate RuboCop todo list

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    11a2887 View commit details
    Browse the repository at this point in the history

  3. Configure EditorConfig settings

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    4a3a652 View commit details
    Browse the repository at this point in the history

  4. LINT: Fix RuboCop issues 

    Layout/SpaceAfterColon
Layout/SpaceInsideParens
Lint/ParenthesesAsGroupedExpression
Rails/WhereEquals
Rails/WhereNot
Style/MethodCallWithoutArgsParentheses
Style/RedundantCondition
Style/SuperWithArgsParentheses
Style/UnlessElse
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8ff47aa View commit details
    Browse the repository at this point in the history

  5. LINT: Fix RuboCop issues 

    Rails/IndexWith
Rails/Pluck
Rails/Present
Rails/RedundantAllowNil
Rails/Validation
Rails/WhereExists
Style/BlockComments
Style/ColonMethodCall
Style/EmptyLiteral
Style/MapCompactWithConditionalBlock
Style/Not
Style/RedundantRegexpArgument
Style/SelfAssignment
Style/Semicolon
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    eab83e9 View commit details
    Browse the repository at this point in the history

  6. LINT: Fix RuboCop performance issues 

    Performance/BlockGivenWithExplicitBlock
Performance/FlatMap
Performance/MapMethodChain
Performance/RedundantBlockCall
Performance/RedundantSortBlock
Performance/RedundantSplitRegexpArgument
Performance/RegexpMatch
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6d6d2be View commit details
    Browse the repository at this point in the history

  7. LINT: Fix RuboCop layout issues

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2bd40e6 View commit details
    Browse the repository at this point in the history

  8. LINT: Fix rubocop issue Lint/AmbiguousOperator

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a02d49c View commit details
    Browse the repository at this point in the history

  9. LINT: Fix rubocop issue Layout/BlockAlignment

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8a8ec8a View commit details
    Browse the repository at this point in the history

  10. LINT: Fix rubocop issue Layout/BlockAlignment

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5283a3e View commit details
    Browse the repository at this point in the history

  11. LINT: Disable rubocop issue Lint/LiteralAsCondition

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    fedb15c View commit details
    Browse the repository at this point in the history

  12. LINT: Disable rubocop issue Lint/NonLocalExitFromIterator

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    91b56e4 View commit details
    Browse the repository at this point in the history

  13. LINT: Fix RuboCop issues 

    Rails/RedundantForeignKey
Style/EachWithObject
Style/EmptyElse
Style/EmptyLambdaParameter
Style/RandomWithOffset
Style/RedundantFreeze
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    60e7fee View commit details
    Browse the repository at this point in the history

  14. LINT: Disable rubocop issue Style/MissingRespondToMissing

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8d2ca27 View commit details
    Browse the repository at this point in the history

  15. LINT: Fix RuboCop issues 

    Rails/ShortI18n
Style/Alias
Style/ClassCheck
Style/FileRead
Style/MultilineIfModifier
Style/RedundantRegexpEscape
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    798a184 View commit details
    Browse the repository at this point in the history

  16. LINT: Fix RuboCop indentation issues

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    01d7c6a View commit details
    Browse the repository at this point in the history

  17. LINT: Fix RuboCop issues

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    54cdc52 View commit details
    Browse the repository at this point in the history

  18. LINT: Fix RuboCop issues unsafe to auto-correct 

    Performance/Sum
Rails/PluckInWhere
Rails/RakeEnvironment
Style/AndOr
Style/For
Style/GlobalStdStream
Style/HashExcept
Style/RedundantSort
Style/StringChars
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9e34753 View commit details
    Browse the repository at this point in the history

  19. LINT: Specify environments for Rails/UnknownEnv rule

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e7f0156 View commit details
    Browse the repository at this point in the history

  20. LINT: Fix rubocop issue Performance/Detect

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    4e73009 View commit details
    Browse the repository at this point in the history

  21. LINT: Fix RuboCop issues

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dd15190 View commit details
    Browse the repository at this point in the history

  22. LINT: Fix rubocop issue Style/RedundantStringEscape

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    2b523c0 View commit details
    Browse the repository at this point in the history

  23. LINT: Fix rubocop issue Style/RedundantSelf

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    4bf47e0 View commit details
    Browse the repository at this point in the history

  24. LINT: Disable rubocop issue Style/ArgumentsForwarding

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e52c9b8 View commit details
    Browse the repository at this point in the history

  25. LINT: Fix rubocop issue Style/ConditionalAssignment

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b300428 View commit details
    Browse the repository at this point in the history

  26. Regenerate RuboCop todo list

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0af652f View commit details
    Browse the repository at this point in the history

  27. LINT: Fix RuboCop issues 

    Layout/SpaceInLambdaLiteral
Layout/SpaceInsidePercentLiteralDelimiters
Rails/Delegate
Lint/EnsureReturn
Rails/ReadWriteAttribute
    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3cce4cd View commit details
    Browse the repository at this point in the history

  28. LINT: Fix rubocop issue Style/RedundantAssignment

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    891b66c View commit details
    Browse the repository at this point in the history

  29. LINT: Fix rubocop issue Style/BarePercentLiterals

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dafc554 View commit details
    Browse the repository at this point in the history

  30. LINT: Fix rubocop issue Style/NestedParenthesizedCalls

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e8b5958 View commit details
    Browse the repository at this point in the history

  31. LINT: Fix rubocop issue Style/IfInsideElse

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5c7a9b6 View commit details
    Browse the repository at this point in the history

  32. LINT: Fix rubocop issue Rails/Blank

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3c15063 View commit details
    Browse the repository at this point in the history

  33. LINT: Fix rubocop issue Style/RedundantPercentQ

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a18fde5 View commit details
    Browse the repository at this point in the history

  34. LINT: Fix rubocop issue Layout/SpaceBeforeBlockBraces

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1fa7bce View commit details
    Browse the repository at this point in the history

  35. LINT: Fix rubocop issue Layout/MultilineArrayBraceLayout

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5386276 View commit details
    Browse the repository at this point in the history

  36. LINT: Fix rubocop issue Lint/SymbolConversion

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7bacab6 View commit details
    Browse the repository at this point in the history

  37. LINT: Fix rubocop issue Layout/SpaceInsideArrayLiteralBrackets

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0eaa23b View commit details
    Browse the repository at this point in the history

  38. LINT: Fix rubocop issue Performance/StringIdentifierArgument

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6c14631 View commit details
    Browse the repository at this point in the history

  39. LINT: Fix rubocop issue Style/PercentLiteralDelimiters

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8d3acdc View commit details
    Browse the repository at this point in the history

  40. LINT: Fix rubocop issue Style/HashSyntax

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6005e69 View commit details
    Browse the repository at this point in the history

  41. LINT: Fix rubocop issue Style/RedundantReturn

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8e9f6b9 View commit details
    Browse the repository at this point in the history

  42. LINT: Fix rubocop issue Performance/StringReplacement

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5ed2a56 View commit details
    Browse the repository at this point in the history

  43. LINT: Fix rubocop issue Lint/UselessAssignment

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    abbd5ec View commit details
    Browse the repository at this point in the history

  44. LINT: Fix rubocop issue Rails/TimeZone

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    144aa0c View commit details
    Browse the repository at this point in the history

  45. LINT: Fix rubocop issue Rails/NegateInclude

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3f3cfa9 View commit details
    Browse the repository at this point in the history

  46. LINT: Fix rubocop issue Rails/ApplicationRecord

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    fdfd026 View commit details
    Browse the repository at this point in the history

  47. LINT: Fix rubocop issue Style/IdenticalConditionalBranches

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b554c52 View commit details
    Browse the repository at this point in the history

  48. LINT: Enforce comma instead of consistent_comma

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5985c09 View commit details
    Browse the repository at this point in the history

  49. LINT: Fix rubocop issue Lint/AssignmentInCondition

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1b65507 View commit details
    Browse the repository at this point in the history

  50. LINT: Fix rubocop issue Lint/DuplicateMethods

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    286bb5e View commit details
    Browse the repository at this point in the history

  51. LINT: Fix rubocop issue Performance/RedundantMerge

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1d45bd8 View commit details
    Browse the repository at this point in the history

  52. LINT: Fix rubocop issue Style/MapIntoArray

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    506d51b View commit details
    Browse the repository at this point in the history

  53. LINT: Fix rubocop issue Style/SlicingWithRange

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7a42455 View commit details
    Browse the repository at this point in the history

  54. LINT: Fix rubocop issue Performance/InefficientHashSearch

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    c24f590 View commit details
    Browse the repository at this point in the history

  55. LINT: Fix rubocop issue Performance/StringInclude

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0213fb7 View commit details
    Browse the repository at this point in the history

  56. LINT: Disable rubocop issue Performance/MapCompact

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    913af88 View commit details
    Browse the repository at this point in the history

  57. LINT: Fix rubocop issue Style/StringLiterals

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    83dbd82 View commit details
    Browse the repository at this point in the history

  58. LINT: Fix rubocop issue Style/MixinUsage

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b1f7256 View commit details
    Browse the repository at this point in the history

  59. Fix code injection warning by checking value against whitelisted values

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9381e34 View commit details
    Browse the repository at this point in the history

  60. LINT: Fix rubocop issue Rails/FilePath

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6f7c29f View commit details
    Browse the repository at this point in the history

  61. LINT: Fix rubocop issue Rails/OutputSafety

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    fbc889f View commit details
    Browse the repository at this point in the history

  62. LINT: Fix rubocop issue Rails/InverseOf

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ed42346 View commit details
    Browse the repository at this point in the history

  63. LINT: Fix rubocop issue Lint/IneffectiveAccessModifier

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    49ab4c7 View commit details
    Browse the repository at this point in the history

  64. LINT: Fix rubocop issue Performance/MapMethodChain

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0cdf8d8 View commit details
    Browse the repository at this point in the history

  65. LINT: Fix rubocop issue Lint/DuplicateMethods

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5426d9c View commit details
    Browse the repository at this point in the history

  66. LINT: Fix rubocop issue Performance/CollectionLiteralInLoop

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    4798b74 View commit details
    Browse the repository at this point in the history

  67. LINT: Disable RuboCop issue Rails/LexicallyScopedActionFilter

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ffe0ee4 View commit details
    Browse the repository at this point in the history

  68. LINT: Move class methods above private section

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    592a7bf View commit details
    Browse the repository at this point in the history

  69. LINT: Disable RuboCop check Rails/SkipsModelValidations

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    77d8ede View commit details
    Browse the repository at this point in the history

  70. LINT: Disable RuboCop issue Rails/HasManyOrHasOneDependent

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7ca153d View commit details
    Browse the repository at this point in the history

  71. LINT: Fix RuboCop issue Rails/Output

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    d313b53 View commit details
    Browse the repository at this point in the history

  72. LINT: Disable RuboCop check Style/SafeNavigation

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    fe1dbb8 View commit details
    Browse the repository at this point in the history

  73. LINT: Disable RuboCop check Lint/BooleanSymbol

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dcdd611 View commit details
    Browse the repository at this point in the history

  74. LINT: Fix RuboCop issue Security/Eval

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    40fa82b View commit details
    Browse the repository at this point in the history

  75. LINT: Disable RuboCop offenses for Rails/UniqueValidationWithoutIndex

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ba8d740 View commit details
    Browse the repository at this point in the history

  76. Whitelist sortable fields/columns

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b70733a View commit details
    Browse the repository at this point in the history

  77. LINT: Fix RuboCop issue Rails/HelperInstanceVariable

    @Lubosky
    Lubosky committed May 19, 2024
    Configuration menu
    Copy the full SHA
    74fdf6c View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Merge branch 'main' into rubocop-upgrade

    @TheDancingClown
    TheDancingClown authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    313e9fb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2919 from bitzesty/rubocop-upgrade 

    RuboCop all the things
    @TheDancingClown
    TheDancingClown authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    273b75c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Sets from and to variables for error

    @TheDancingClown
    TheDancingClown committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    279e9c5 View commit details
    Browse the repository at this point in the history

  2. fix simplecov configuration to report relevant spec coverage

    @dreamfall @Lubosky
    dreamfall authored and Lubosky committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    fc1164c View commit details
    Browse the repository at this point in the history

  3. add specs on form/account controllers

    @dreamfall @Lubosky
    dreamfall authored and Lubosky committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7a2454e View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2963 from bitzesty/improve-spec-coverage 

    Improve spec coverage
    @Lubosky
    Lubosky authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4561fe5 View commit details
    Browse the repository at this point in the history

  5. Removes custom error validation

    @TheDancingClown
    TheDancingClown committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    a62a752 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into a11y-radio

    @TheDancingClown
    TheDancingClown authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    512dd99 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #2964 from bitzesty/a11y-radio 

    Sets from and to variables for error method in RecentFinancialYearQuestion
    @TheDancingClown
    TheDancingClown authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    3903fb3 View commit details
    Browse the repository at this point in the history