Staging < main #2966
Merged
Staging < main #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layout/SpaceAfterColon Layout/SpaceInsideParens Lint/ParenthesesAsGroupedExpression Rails/WhereEquals Rails/WhereNot Style/MethodCallWithoutArgsParentheses Style/RedundantCondition Style/SuperWithArgsParentheses Style/UnlessElse
Rails/IndexWith Rails/Pluck Rails/Present Rails/RedundantAllowNil Rails/Validation Rails/WhereExists Style/BlockComments Style/ColonMethodCall Style/EmptyLiteral Style/MapCompactWithConditionalBlock Style/Not Style/RedundantRegexpArgument Style/SelfAssignment Style/Semicolon
Performance/BlockGivenWithExplicitBlock Performance/FlatMap Performance/MapMethodChain Performance/RedundantBlockCall Performance/RedundantSortBlock Performance/RedundantSplitRegexpArgument Performance/RegexpMatch
Rails/RedundantForeignKey Style/EachWithObject Style/EmptyElse Style/EmptyLambdaParameter Style/RandomWithOffset Style/RedundantFreeze
Rails/ShortI18n Style/Alias Style/ClassCheck Style/FileRead Style/MultilineIfModifier Style/RedundantRegexpEscape
Performance/Sum Rails/PluckInWhere Rails/RakeEnvironment Style/AndOr Style/For Style/GlobalStdStream Style/HashExcept Style/RedundantSort Style/StringChars
Layout/SpaceInLambdaLiteral Layout/SpaceInsidePercentLiteralDelimiters Rails/Delegate Lint/EnsureReturn Rails/ReadWriteAttribute
RuboCop all the things
Improve spec coverage
Sets from and to variables for error method in RecentFinancialYearQuestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 A short description of the changes