-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-8280] email forwarders #11563
Open
audreyality
wants to merge
42
commits into
main
Choose a base branch
from
tools/PM-8280/email-forwarders
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[PM-8280] email forwarders #11563
+3,271
−922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
audreyality
force-pushed
the
tools/PM-8280/email-forwarders
branch
from
October 16, 2024 17:00
9db9bfd
to
d5a19ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8280
📔 Objective
Add forwarder support to credential generator
UserStateSubject
with classifier & encryptor supportUserStateSubject
ObjectKey
to support encryption to POJOs in state storageCredentialGeneratorService
with forwarder integration support:{ forwarder: IntegrationId }
algorithm Id to model service integrationForwarderEngine
to invoke RPCs in response to generator requests.AlgorithmInfo
to model localized credential generation metadata.🏁 Remaining tasks
Use import configuration for settings migrationsplit to PM-13733UserStateSubject
🦕 System Evolution
Switching to
{ 'engine': EngineId }
for built-in generators could improve cohesion throughout the generator system. It also eliminates confusion between the'username'
category and the{ engine: 'username' }
engineId.Promote
ObjectKey
to a class. Several of the methods inUserStateSubject
, particularly those used before classification, properly belong inObjectKey
.ObjectKey
should also provide an optional serializer for parity with its deserializer.📸 Screenshots
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes