-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13776] Generator Icon Button labels #11623
base: main
Are you sure you want to change the base?
Conversation
… components - Using the `appA11yTitle` across all icon buttons - Updated all labels to be targeted towards the credential type rather than just "password"
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11623 +/- ##
=======================================
Coverage 33.23% 33.23%
=======================================
Files 2782 2782
Lines 86526 86526
Branches 16488 16488
=======================================
Hits 28759 28759
Misses 55477 55477
Partials 2290 2290 ☔ View full report in Codecov by Sentry. |
No New Or Fixed Issues Found |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected credentialTypeCopyLabel$ = this.root$.pipe( | ||
map(({ nav }) => { | ||
if (nav === "password") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌱 The forwarder PR (#11563) moves translation into the service. Please put FIXME
comments on each of these labels to move them into the algorithm metadata once that branch lands.
protected credentialTypeCopyLabel$ = this.root$.pipe( | |
map(({ nav }) => { | |
if (nav === "password") { | |
protected credentialTypeCopyLabel$ = this.root$.pipe( | |
// FIXME: add labels to `AlgorithmInfo` and perform translation in the `CredentialGeneratorService` | |
map(({ nav }) => { | |
if (nav === "password") { |
The above suggestion is an example; the FIXME should be applied in every location where this code exists, and also as an HTML comment (<!-- -->
) in the username generator UI where there's a fixed label.
🎟️ Tracking
PM-13776
📔 Objective
Update aria labels for generate and copy buttons within the generator components
appA11yTitle
across all icon buttons📸 Screenshots
labels-before.mov
labels-after-extension.mov
labels-after-web.mov
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes